From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF8FC4332F for ; Mon, 6 Nov 2023 13:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232815AbjKFNeY (ORCPT ); Mon, 6 Nov 2023 08:34:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232840AbjKFNeX (ORCPT ); Mon, 6 Nov 2023 08:34:23 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6A2E1B2 for ; Mon, 6 Nov 2023 05:34:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16A6EC433C7; Mon, 6 Nov 2023 13:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699277659; bh=CQYWp2CYQRZVtvYsgVkNS/5lSgiowZAibSqDkeNZhHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LDU6ARGlWI3PzOiV+7C/QyGQro5YDOd13kT2dQskr9YMALu1t043YjauDsnLAaxoQ zoJ1+lQnA632DL/o9jb6eB/iLV0irjeXN8aweac4Toill+pVCzcpugB8hK6+ZvQ0hu Sq8POhH8pDLokHkzrV6X9JMb0V9LFleYZCdyc90I= From: Greg Kroah-Hartman To: stable@vger.kernel.org, lee@kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Krzysztof Kozlowski Subject: [PATCH 5.10 55/95] rpmsg: Constify local variable in field store macro Date: Mon, 6 Nov 2023 14:04:23 +0100 Message-ID: <20231106130306.700282260@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231106130304.678610325@linuxfoundation.org> References: <20231106130304.678610325@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krzysztof Kozlowski commit e5f89131a06142e91073b6959d91cea73861d40e upstream. Memory pointed by variable 'old' in field store macro is not modified, so it can be made a pointer to const. Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220419113435.246203-12-krzysztof.kozlowski@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/rpmsg/rpmsg_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -332,7 +332,8 @@ field##_store(struct device *dev, struct const char *buf, size_t sz) \ { \ struct rpmsg_device *rpdev = to_rpmsg_device(dev); \ - char *new, *old; \ + const char *old; \ + char *new; \ \ new = kstrndup(buf, sz, GFP_KERNEL); \ if (!new) \