From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE42C4332F for ; Mon, 6 Nov 2023 13:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232627AbjKFN1i (ORCPT ); Mon, 6 Nov 2023 08:27:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232625AbjKFN1h (ORCPT ); Mon, 6 Nov 2023 08:27:37 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3817CD8 for ; Mon, 6 Nov 2023 05:27:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79D6BC433C7; Mon, 6 Nov 2023 13:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699277254; bh=cfHfLeYBAX9dZha+dsn6erNF66K66iajSfYMZHC4PLw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=whtL9rU6jN71lI4dgmP8VA3XOU1uwCLwmQjKzCy/AlqyKz2U4hmIneyjpbz8Cz1MK mtHKv8FEdXuzCGZS8gVpt27O70LGilBjFPUHMPK6namZwN1PXz1Gq8o/e9D2NYiXQg SBQAMtTBJ50L7DD3wuN8jz+ONChPIy0r0Vzxp+so= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Su Hui , Konstantin Komarov , Sasha Levin Subject: [PATCH 5.15 089/128] fs/ntfs3: Avoid possible memory leak Date: Mon, 6 Nov 2023 14:04:09 +0100 Message-ID: <20231106130313.187365236@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231106130309.112650042@linuxfoundation.org> References: <20231106130309.112650042@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Su Hui [ Upstream commit e4494770a5cad3c9d1d2a65ed15d07656c0d9b82 ] smatch warn: fs/ntfs3/fslog.c:2172 last_log_lsn() warn: possible memory leak of 'page_bufs' Jump to label 'out' to free 'page_bufs' and is more consistent with other code. Signed-off-by: Su Hui Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/fslog.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c index 59f813cbdaa8e..8b95c06e5a4c5 100644 --- a/fs/ntfs3/fslog.c +++ b/fs/ntfs3/fslog.c @@ -2169,8 +2169,10 @@ static int last_log_lsn(struct ntfs_log *log) if (!page) { page = kmalloc(log->page_size, GFP_NOFS); - if (!page) - return -ENOMEM; + if (!page) { + err = -ENOMEM; + goto out; + } } /* -- 2.42.0