Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mahmoud Adam <mngyadam@amazon.com>
Cc: stable@vger.kernel.org
Subject: Re: backport "x86: change default to spec_store_bypass_disable=prctl spectre_v2_user=prctl"
Date: Mon, 6 Nov 2023 10:19:32 +0100	[thread overview]
Message-ID: <2023110617-had-drier-c367@gregkh> (raw)
In-Reply-To: <lrkyq4ji533oz.fsf@dev-dsk-mngyadam-1c-a2602c62.eu-west-1.amazon.com>

On Wed, Nov 01, 2023 at 04:15:24PM +0100, Mahmoud Adam wrote:
> > Why is this required at all?  It just changes a default option, you can
> > set the "faster" option yourself if you really feel it is a good idea
> > for older kernels, why can't you do that for containers you want it
> > enabled on for these older kernels?
> 
> The patch has already motivations of why this is a better default, and
> changing this would give performance improvements
> 
> > And what exact kernel versions did you test this on?
> 
> this was tested on 5.15 and 5.10
> 
> > And how is this not a new feature?
> 
> As you mentioned it changes the default option, Why is this considered a
> new feature?

Changing the default option when booting is a new feature in that it
changes what was previously happening before.

And, anyone running those old kernels, if they are comfortable with
making this feature the default, in order to get the performance
increase you say is there, can change their command line to do so, no
kernel changes needed.

So for now, I'll leave this as-is, thanks.

greg k-h

      reply	other threads:[~2023-11-06  9:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 14:28 backport "x86: change default to spec_store_bypass_disable=prctl spectre_v2_user=prctl" Mahmoud Adam
2023-10-14  9:27 ` Greg KH
2023-11-01 15:15   ` Mahmoud Adam
2023-11-06  9:19     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023110617-had-drier-c367@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=mngyadam@amazon.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox