From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5008AC4167B for ; Tue, 7 Nov 2023 12:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343531AbjKGMj6 (ORCPT ); Tue, 7 Nov 2023 07:39:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343844AbjKGMjV (ORCPT ); Tue, 7 Nov 2023 07:39:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08AF54C34; Tue, 7 Nov 2023 04:13:04 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45FCAC433C7; Tue, 7 Nov 2023 12:13:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699359184; bh=z/XUYf/UYqe5SY3BaU1pxVt9kzydhnPweHjbLdvjtH8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zy4zz7m6WvaPuCOxhFSnpxRhK6Hb1FjrCM2J1mRGIu2BIlCCn0wsC9KZwsWXeidJV jPRtwnGYLdKi0mvkAiOPYUMIerZ/P7nA4w1Y0bHVWTFko8gnlz+WYDiYcEUwKAlq5l tttemnLbRO8nks0+Yx5bFCjzoKxb34h+YTQBfzKM8fItx1yG4AzVjuUw2zjZKDO8JJ H2jg/P1jdc5zl9KWFvfGIZ5mlwe/uyXXshFHrUac85lPgu4GicGEIVwqxuLycsHgiU rzWmxDobZqY0PEZk9C/HO6J6JlTnijSQkTWBsUcAhJWjQm4P5VXQ9sOafkrJcEI6oQ KT2rLY+kp3kug== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dmitry Antipov , Jeff Johnson , Kalle Valo , Sasha Levin , kvalo@kernel.org, nathan@kernel.org, ndesaulniers@google.com, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH AUTOSEL 5.4 4/9] wifi: ath10k: fix clang-specific fortify warning Date: Tue, 7 Nov 2023 07:12:47 -0500 Message-ID: <20231107121256.3758858-4-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107121256.3758858-1-sashal@kernel.org> References: <20231107121256.3758858-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.259 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dmitry Antipov [ Upstream commit cb4c132ebfeac5962f7258ffc831caa0c4dada1a ] When compiling with clang 16.0.6 and CONFIG_FORTIFY_SOURCE=y, I've noticed the following (somewhat confusing due to absence of an actual source code location): In file included from drivers/net/wireless/ath/ath10k/debug.c:8: In file included from ./include/linux/module.h:13: In file included from ./include/linux/stat.h:19: In file included from ./include/linux/time.h:60: In file included from ./include/linux/time32.h:13: In file included from ./include/linux/timex.h:67: In file included from ./arch/x86/include/asm/timex.h:5: In file included from ./arch/x86/include/asm/processor.h:23: In file included from ./arch/x86/include/asm/msr.h:11: In file included from ./arch/x86/include/asm/cpumask.h:5: In file included from ./include/linux/cpumask.h:12: In file included from ./include/linux/bitmap.h:11: In file included from ./include/linux/string.h:254: ./include/linux/fortify-string.h:592:4: warning: call to '__read_overflow2_field' declared with 'warning' attribute: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Wattribute-warning] __read_overflow2_field(q_size_field, size); The compiler actually complains on 'ath10k_debug_get_et_strings()' where fortification logic inteprets call to 'memcpy()' as an attempt to copy the whole 'ath10k_gstrings_stats' array from it's first member and so issues an overread warning. This warning may be silenced by passing an address of the whole array and not the first member to 'memcpy()'. Signed-off-by: Dmitry Antipov Acked-by: Jeff Johnson Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20230829093652.234537-1-dmantipov@yandex.ru Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index 04c50a26a4f47..34db968c4bd0b 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -1138,7 +1138,7 @@ void ath10k_debug_get_et_strings(struct ieee80211_hw *hw, u32 sset, u8 *data) { if (sset == ETH_SS_STATS) - memcpy(data, *ath10k_gstrings_stats, + memcpy(data, ath10k_gstrings_stats, sizeof(ath10k_gstrings_stats)); } -- 2.42.0