From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE41C4167D for ; Tue, 7 Nov 2023 12:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235173AbjKGMkE (ORCPT ); Tue, 7 Nov 2023 07:40:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235213AbjKGMib (ORCPT ); Tue, 7 Nov 2023 07:38:31 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ADA01BFC; Tue, 7 Nov 2023 04:26:42 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4162CC433C9; Tue, 7 Nov 2023 12:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699360002; bh=T7+Z33cR3LGew98mYjyHF8lRE2/3d+0jjAWDb57Xl90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tQvs3kkWWThPU3MXrMqANYnz3YmOhD5Ci8m8fvC8EiJsulny3pjKKEj0aAJTPTUXH ojqxJni8In9BndZfR5xtajjhSScZAVMryD22r6DhLlu8jABcJXXeCC5wVzZdswOlds 8rsrcXZT1FHHfjhic8Hqad+QpiwCpnVzx+AgSaNZH9QnwpFWs7OFzT8QPFivhLAQa9 ESDSOJJRdaSTN8G00uVNwA+naGMeJE4C4OBWd+D4u8F5wCbOq0g9fBoO+QhZRUaa2B utUq/mtipWPl7CXjQf4VyxR3rCEyfmxplDsAwQTBdnQ324/jcEHq7Sbjuke9OFdIlv nO3wdWnZs5fKg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Lin.Cao" , Jingwen Chen , Alex Deucher , Sasha Levin , evan.quan@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, lijo.lazar@amd.com, mario.limonciello@amd.com, Hawking.Zhang@amd.com, guchun.chen@amd.com, Lyndon.Li@amd.com, bokun.zhang@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.5 32/37] drm/amd: check num of link levels when update pcie param Date: Tue, 7 Nov 2023 07:21:43 -0500 Message-ID: <20231107122407.3760584-32-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107122407.3760584-1-sashal@kernel.org> References: <20231107122407.3760584-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.5.10 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: "Lin.Cao" [ Upstream commit 406e8845356d18bdf3d3a23b347faf67706472ec ] In SR-IOV environment, the value of pcie_table->num_of_link_levels will be 0, and num_of_levels - 1 will cause array index out of bounds Signed-off-by: Lin.Cao Acked-by: Jingwen Chen Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c index 223e890575a2b..3bc60ecc7bfef 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c @@ -2436,6 +2436,9 @@ int smu_v13_0_update_pcie_parameters(struct smu_context *smu, uint32_t smu_pcie_arg; int ret, i; + if (!num_of_levels) + return 0; + if (!(smu->adev->pm.pp_feature & PP_PCIE_DPM_MASK)) { if (pcie_table->pcie_gen[num_of_levels - 1] < pcie_gen_cap) pcie_gen_cap = pcie_table->pcie_gen[num_of_levels - 1]; -- 2.42.0