From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42AFAC4167D for ; Tue, 7 Nov 2023 12:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343697AbjKGMne (ORCPT ); Tue, 7 Nov 2023 07:43:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235280AbjKGMnI (ORCPT ); Tue, 7 Nov 2023 07:43:08 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BA433DA0; Tue, 7 Nov 2023 04:30:27 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59C71C433CA; Tue, 7 Nov 2023 12:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699360226; bh=LHx0a0WlPZb3j8jizZed3N+JMptFlxPvM8e7WBd3j94=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UYBZSAQEHvvUXJwoNUdevvyosBX+pEvbIjWLfxdU0uLOmQJZcQSBEgJZ/j0hO/r19 Oly5ucPbp5tOU3L4T0iJ6WeT4MxutiJ16MlOYowdT1bbMlGwV6xmqACuPkn11lArBV oS49pVIeVLbKuYP6fnLtDBUxdZGfsAcSegDKPX6LzKk5GykRndO2R3q6R8x823RnLq Zq0If8YApCEv2maZy2aYDWuIPHng0t7ybS9siLt0l8MGkUpIb3UU3qXfVGLPhOtAuV y+r0gFGzlXR8TvwU3jPNe9mBn51QNx803ruSALznQ4IEgDYkgHCck3yb8AU+jFCjBR JF9Cvh+bav5Qg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ma Ke , Neil Armstrong , Sasha Levin , linus.walleij@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.15 14/20] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference Date: Tue, 7 Nov 2023 07:29:08 -0500 Message-ID: <20231107122940.3762228-14-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107122940.3762228-1-sashal@kernel.org> References: <20231107122940.3762228-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.137 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ma Ke [ Upstream commit f22def5970c423ea7f87d5247bd0ef91416b0658 ] In tpg110_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke Reviewed-by: Neil Armstrong Link: https://lore.kernel.org/r/20231009090446.4043798-1-make_ruc2021@163.com Signed-off-by: Neil Armstrong Link: https://patchwork.freedesktop.org/patch/msgid/20231009090446.4043798-1-make_ruc2021@163.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/panel/panel-tpo-tpg110.c index e3791dad6830c..3360e7ccb0a7d 100644 --- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c +++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c @@ -379,6 +379,8 @@ static int tpg110_get_modes(struct drm_panel *panel, connector->display_info.bus_flags = tpg->panel_mode->bus_flags; mode = drm_mode_duplicate(connector->dev, &tpg->panel_mode->mode); + if (!mode) + return -ENOMEM; drm_mode_set_name(mode); mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; -- 2.42.0