From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE751C04A95 for ; Tue, 7 Nov 2023 13:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234779AbjKGNu0 (ORCPT ); Tue, 7 Nov 2023 08:50:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234841AbjKGNuI (ORCPT ); Tue, 7 Nov 2023 08:50:08 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2336D30153; Tue, 7 Nov 2023 04:31:28 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74D62C433C8; Tue, 7 Nov 2023 12:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699360287; bh=2uCsRE/8c6B0RMRw5fnErNNJ+mLfF4psmSlh3dF0mbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e2wbwPbv6x3zrT3drv5YlafGf5udnWsCwXyctqTjC7gEryeqUqN+nBabe8+hCk+nb 88DjvM1VoKCVykuI32LHIBM5bQBA3nmvnBjf/rSRBjdp3Lou+nSP9CEdB0XqE+wfKM PpNjOUEbu5Q9mCxCwpSPUrXgJ4aod4IZj/Vhg9tZRA5wb29D8LsbNftV/FvfLVtOd4 63mwsZXnk9bY6+h/iHITx54LOLzKKTSpKq+Eb4Ni8ZD/5cEdV3W0ty+AxtbncpfaHa P5k7vnGbkVSYxhoNAvQ2+f/fIigF/WVgTz2JgdPjv9cqXnbNkfHeDVYHSVboFBD/ZI +shG0n+yDQ6fA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ma Ke , Neil Armstrong , Sasha Levin , linus.walleij@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.10 08/11] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference Date: Tue, 7 Nov 2023 07:30:41 -0500 Message-ID: <20231107123100.3762796-8-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107123100.3762796-1-sashal@kernel.org> References: <20231107123100.3762796-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.199 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ma Ke [ Upstream commit f22def5970c423ea7f87d5247bd0ef91416b0658 ] In tpg110_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke Reviewed-by: Neil Armstrong Link: https://lore.kernel.org/r/20231009090446.4043798-1-make_ruc2021@163.com Signed-off-by: Neil Armstrong Link: https://patchwork.freedesktop.org/patch/msgid/20231009090446.4043798-1-make_ruc2021@163.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/panel/panel-tpo-tpg110.c index d57ed75a977c3..494cec50a682b 100644 --- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c +++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c @@ -378,6 +378,8 @@ static int tpg110_get_modes(struct drm_panel *panel, connector->display_info.bus_flags = tpg->panel_mode->bus_flags; mode = drm_mode_duplicate(connector->dev, &tpg->panel_mode->mode); + if (!mode) + return -ENOMEM; drm_mode_set_name(mode); mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; -- 2.42.0