From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98008C4332F for ; Tue, 7 Nov 2023 12:46:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343826AbjKGMqd (ORCPT ); Tue, 7 Nov 2023 07:46:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234353AbjKGMqD (ORCPT ); Tue, 7 Nov 2023 07:46:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47FE8152CE; Tue, 7 Nov 2023 04:32:42 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C271C433C7; Tue, 7 Nov 2023 12:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699360361; bh=IaD5LuAKOSRiEqSUbXrGBACv2jpcb8C7CQaFLspeXIg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ccmUVdx1d8EiTFjGnN9zHuqcZqXn5luzBpSRmZUHwJtGx06p/4NHmAH0hz52NC1Ie VxJ5xpmis/ZGmiGRCq/PFDEue0sgsbYMVfhuWmF43i4tWRTNre72VXd+1i3GcJvgFm nqkHG0I8Wg8C/7QQvoMR4pA3uyJFux2ile24Ng3D/JDk3fzwvlNiVFSX81L31/vowM MBNNAlTpC9C6+QONOBc1Y41yW84aVy+ItHAlaViNNIeqa28Z6zixByX911EQgKsRnX 38qiXNT5Ru6qt8rz4+wlMIIlArqNHWPm0q4uMnmlH75mElomeXzZtXOe09T9daC4U/ sFLVUkohyyg/w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: zhujun2 , Shuah Khan , Sasha Levin , shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 5/5] selftests/efivarfs: create-read: fix a resource leak Date: Tue, 7 Nov 2023 07:32:10 -0500 Message-ID: <20231107123225.3763221-5-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107123225.3763221-1-sashal@kernel.org> References: <20231107123225.3763221-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.297 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/efivarfs/create-read.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c index 9674a19396a32..7bc7af4eb2c17 100644 --- a/tools/testing/selftests/efivarfs/create-read.c +++ b/tools/testing/selftests/efivarfs/create-read.c @@ -32,8 +32,10 @@ int main(int argc, char **argv) rc = read(fd, buf, sizeof(buf)); if (rc != 0) { fprintf(stderr, "Reading a new var should return EOF\n"); + close(fd); return EXIT_FAILURE; } + close(fd); return EXIT_SUCCESS; } -- 2.42.0