From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71111C4332F for ; Sun, 12 Nov 2023 17:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjKLRjo (ORCPT ); Sun, 12 Nov 2023 12:39:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjKLRjo (ORCPT ); Sun, 12 Nov 2023 12:39:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DBFF211B; Sun, 12 Nov 2023 09:39:41 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80743C433C7; Sun, 12 Nov 2023 17:39:40 +0000 (UTC) Date: Sun, 12 Nov 2023 12:39:38 -0500 From: Steven Rostedt To: LKML , stable Cc: Greg Kroah-Hartman , Masami Hiramatsu , Mark Rutland , Milian Wolff , akaher@vmware.com, Andrew Morton Subject: Re: [v6.6][PATCH] eventfs: Check for NULL ef in eventfs_set_attr() Message-ID: <20231112123938.58bb5c74@rorschach.local.home> In-Reply-To: <20231112121817.2713c150@rorschach.local.home> References: <20231112121817.2713c150@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, 12 Nov 2023 12:18:17 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The top level events directory dentry does not have a d_fsdata set to a > eventfs_file pointer. This dentry is still passed to eventfs_set_attr(). > It can not assume that the d_fsdata is set. Check for that. > > Link: https://lore.kernel.org/all/20231112104158.6638-1-milian.wolff@kdab.com/ > > Fixes: 9aaee3eebc91 ("eventfs: Save ownership and mode") > Reported-by: Milian Wolff > Signed-off-by: Steven Rostedt (Google) I guess I should have included the "Cc: stable" tag. This is a bit different patch since it's not going to land in upstream, as the bug doesn't exist there. I can resend if needed. -- Steve