From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89FB5C54FB9 for ; Wed, 15 Nov 2023 20:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344262AbjKOUEP (ORCPT ); Wed, 15 Nov 2023 15:04:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344259AbjKOUEO (ORCPT ); Wed, 15 Nov 2023 15:04:14 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FF86B9 for ; Wed, 15 Nov 2023 12:04:11 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1DE9C433C9; Wed, 15 Nov 2023 20:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700078651; bh=2Xn2XbwCl76map8X6lviSr3mbdGVHwyrj1VNFXccbIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KTeaeVaa2CSYK6xts20otvLPBYvviYmtsX6LGEsA5Z5CxCec/pXl1tDtJCM+7spMG vvNH7AiuOlDD0ur9Bpww9tpYRJQ/Ep0Cao0QIMofmAXAwTxdzThsZbNdA/cfsjC2ob +g5IaXONLLQuAQlrEO4bEE0hZ/KNS5MANfqi3gv0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dinghao Liu , Lee Jones , Sasha Levin Subject: [PATCH 4.14 24/45] mfd: dln2: Fix double put in dln2_probe Date: Wed, 15 Nov 2023 14:33:01 -0500 Message-ID: <20231115191421.031021447@linuxfoundation.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231115191419.641552204@linuxfoundation.org> References: <20231115191419.641552204@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dinghao Liu [ Upstream commit 759c409bc5fc496cbc22cd0b392d3cbb0c0e23eb ] The dln2_free() already contains usb_put_dev(). Therefore, the redundant usb_put_dev() before dln2_free() may lead to a double free. Fixes: 96da8f148396 ("mfd: dln2: Fix memory leak in dln2_probe()") Signed-off-by: Dinghao Liu Link: https://lore.kernel.org/r/20230925024134.9683-1-dinghao.liu@zju.edu.cn Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/dln2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index a0ad99ca495fd..97a69cd6f1278 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -804,7 +804,6 @@ static int dln2_probe(struct usb_interface *interface, dln2_stop_rx_urbs(dln2); out_free: - usb_put_dev(dln2->usb_dev); dln2_free(dln2); return ret; -- 2.42.0