From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927ADC2BB3F for ; Wed, 15 Nov 2023 20:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344659AbjKOU6H (ORCPT ); Wed, 15 Nov 2023 15:58:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344661AbjKOU5h (ORCPT ); Wed, 15 Nov 2023 15:57:37 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A733A19B for ; Wed, 15 Nov 2023 12:57:26 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D54B4C36AE6; Wed, 15 Nov 2023 20:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700081386; bh=5KVvaeE6oACZ2P0gKDoinK8AX8JzdbPFJDYvguIxWIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1w0h7yEwMHfI2H0Z/h1dAwcqL0gKJo0JVp8xzKECFwCkerYdTIl+YIydlmlTmcwjy dpOmFvpisYGwDBFvD6gQz19nziIugozFt4+SJrrkLAb1ph9A1kaNP5HX+hB4AQE/qg nw4+bZS0to/MxdpeQCYSukMOrD/hQGTVZ/xba1/Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cristian Marussi , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Sudeep Holla , Sasha Levin Subject: [PATCH 5.15 122/244] clk: scmi: Free scmi_clk allocated when the clocks with invalid info are skipped Date: Wed, 15 Nov 2023 15:35:14 -0500 Message-ID: <20231115203555.683095591@linuxfoundation.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231115203548.387164783@linuxfoundation.org> References: <20231115203548.387164783@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sudeep Holla [ Upstream commit 3537a75e73f3420614a358d0c8b390ea483cc87d ] Add the missing devm_kfree() when we skip the clocks with invalid or missing information from the firmware. Cc: Cristian Marussi Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Fixes: 6d6a1d82eaef ("clk: add support for clocks provided by SCMI") Link: https://lore.kernel.org/r/20231004193600.66232-1-sudeep.holla@arm.com Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/clk/clk-scmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c index 1e357d364ca26..a26027597a0ac 100644 --- a/drivers/clk/clk-scmi.c +++ b/drivers/clk/clk-scmi.c @@ -178,6 +178,7 @@ static int scmi_clocks_probe(struct scmi_device *sdev) sclk->info = scmi_proto_clk_ops->info_get(ph, idx); if (!sclk->info) { dev_dbg(dev, "invalid clock info for idx %d\n", idx); + devm_kfree(dev, sclk); continue; } -- 2.42.0