public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net 1/2] net: ti: am65-cpsw-nuss: Fix devlink warning on module removal
       [not found] <20231116110930.36244-1-rogerq@kernel.org>
@ 2023-11-16 11:09 ` Roger Quadros
  0 siblings, 0 replies; only message in thread
From: Roger Quadros @ 2023-11-16 11:09 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni
  Cc: vladimir.oltean, s-vadapalli, r-gunasekaran, vigneshr, srk,
	netdev, linux-kernel, Roger Quadros, stable

devlink_port_unregister() should be called after unregister_netdev()
so that the devlink_port->type is set to DEVLINK_PORT_TYPE_NOTSET
and avoids the below warning.

[   48.511030] WARNING: CPU: 2 PID: 683 at net/devlink/port.c:1077 devl_port_unregister+0x80/0xa8

CC: stable@vger.kernel.org # v6.6+
Fixes: 58356eb31d60 ("net: ti: am65-cpsw-nuss: Add devlink support")
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index ece9f8df98ae..cbbede094b2c 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -3011,13 +3011,13 @@ static int am65_cpsw_nuss_remove(struct platform_device *pdev)
 	if (ret < 0)
 		return ret;
 
-	am65_cpsw_unregister_devlink(common);
 	am65_cpsw_unregister_notifiers(common);
 
 	/* must unregister ndevs here because DD release_driver routine calls
 	 * dma_deconfigure(dev) before devres_release_all(dev)
 	 */
 	am65_cpsw_nuss_cleanup_ndev(common);
+	am65_cpsw_unregister_devlink(common);
 	am65_cpsw_nuss_phylink_cleanup(common);
 	am65_cpts_release(common->cpts);
 	am65_cpsw_disable_serdes_phy(common);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-11-16 11:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20231116110930.36244-1-rogerq@kernel.org>
2023-11-16 11:09 ` [PATCH net 1/2] net: ti: am65-cpsw-nuss: Fix devlink warning on module removal Roger Quadros

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox