public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	mengyuanlou@net-swift.com, stable@vger.kernel.org
Subject: Re: [PATCH net] net: wangxun: fix kernel panic due to null pointer
Date: Sun, 19 Nov 2023 19:27:02 +0000	[thread overview]
Message-ID: <20231119192702.GF186930@vergenet.net> (raw)
In-Reply-To: <20231117101108.893335-1-jiawenwu@trustnetic.com>

On Fri, Nov 17, 2023 at 06:11:08PM +0800, Jiawen Wu wrote:
> When the device uses a custom subsystem vendor ID, the function
> wx_sw_init() returns before the memory of 'wx->mac_table' is allocated.
> The null pointer will causes the kernel panic.
> 
> Fixes: 79625f45ca73 ("net: wangxun: Move MAC address handling to libwx")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Thanks Jiawen Wu,

I agree with your analysis and that the problem was introduced by the cited
commit. The fix also looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

  parent reply	other threads:[~2023-11-19 19:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 10:11 [PATCH net] net: wangxun: fix kernel panic due to null pointer Jiawen Wu
2023-11-17 10:11 ` kernel test robot
2023-11-19 19:27 ` Simon Horman [this message]
2023-11-19 19:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231119192702.GF186930@vergenet.net \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=kuba@kernel.org \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox