From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ECD839FD9; Fri, 24 Nov 2023 18:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kfityC1X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8FC8C433C9; Fri, 24 Nov 2023 18:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700849678; bh=L3xcZN1k+x5nk9pdc1FyyP7HQLmu0pZzpBJf2ZAcyrY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kfityC1XYYmQcjFdBo1hkNtPd36MWXd9hKMLWsOLWBBK8Cct6rBKDhV6A6p7q11oW K/KwKaqtXfgQzbvMI6CXBoQQbUss85fxy3Mopr5hRILOEJcpOj6jwCdngpu/HV6VfA S63keDiGOyM3UWHEu+GQjE4/J6yUjGXNjUVrDafg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Helge Deller Subject: [PATCH 6.6 277/530] fbdev: stifb: Make the STI next font pointer a 32-bit signed offset Date: Fri, 24 Nov 2023 17:47:23 +0000 Message-ID: <20231124172036.473261962@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231124172028.107505484@linuxfoundation.org> References: <20231124172028.107505484@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Helge Deller commit 8a32aa17c1cd48df1ddaa78e45abcb8c7a2220d6 upstream. The pointer to the next STI font is actually a signed 32-bit offset. With this change the 64-bit kernel will correctly subract the (signed 32-bit) offset instead of adding a (unsigned 32-bit) offset. It has no effect on 32-bit kernels. This fixes the stifb driver with a 64-bit kernel on qemu. Signed-off-by: Helge Deller Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- include/video/sticore.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/video/sticore.h +++ b/include/video/sticore.h @@ -232,7 +232,7 @@ struct sti_rom_font { u8 height; u8 font_type; /* language type */ u8 bytes_per_char; - u32 next_font; + s32 next_font; /* note: signed int */ u8 underline_height; u8 underline_pos; u8 res008[2];