* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-25 16:32 [PATCH 4.14 00/53] 4.14.331-rc2 review Greg Kroah-Hartman
@ 2023-11-25 20:10 ` Pavel Machek
2023-11-26 18:33 ` Guenter Roeck
` (5 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Pavel Machek @ 2023-11-25 20:10 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
Hi!
> This is the start of the stable review cycle for the 4.14.331 release.
> There are 53 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.14.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-25 16:32 [PATCH 4.14 00/53] 4.14.331-rc2 review Greg Kroah-Hartman
2023-11-25 20:10 ` Pavel Machek
@ 2023-11-26 18:33 ` Guenter Roeck
2023-11-26 20:39 ` Helge Deller
2023-11-27 5:47 ` Harshit Mogalapalli
` (4 subsequent siblings)
6 siblings, 1 reply; 18+ messages in thread
From: Guenter Roeck @ 2023-11-26 18:33 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, Helge Deller
On 11/25/23 08:32, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.331 release.
> There are 53 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Mon, 27 Nov 2023 16:30:48 +0000.
> Anything received after that time might be too late.
>
Building parisc64:generic-64bit_defconfig ... failed
--------------
Error log:
hppa64-linux-ld: arch/parisc/kernel/head.o: in function `$iodc_panic':
(.head.text+0x64): undefined reference to `init_stack'
hppa64-linux-ld: (.head.text+0x68): undefined reference to `init_stack'
make[1]: *** [Makefile:1049: vmlinux] Error 1
make: *** [Makefile:153: sub-make] Error 2
Bisect log:
# bad: [39ca2c4cec46e5ef545815f62be91cba998b8927] Linux 4.14.331-rc2
# good: [bfa43eeca4797e58975ba8c54057c1f29bf20534] Linux 4.14.330
git bisect start 'HEAD' 'v4.14.330'
# good: [5bc5bf29b42fb16faa4407f9c01f05dadb397f2f] media: venus: hfi: add checks to perform sanity on queue pointers
git bisect good 5bc5bf29b42fb16faa4407f9c01f05dadb397f2f
# good: [2e1d20a37188fbca246de24800f3fb0e9ab8d233] mcb: fix error handling for different scenarios when parsing
git bisect good 2e1d20a37188fbca246de24800f3fb0e9ab8d233
# bad: [6c59b6c8a0be15fa1db3d07ffcad481aa507f8be] media: venus: hfi: fix the check to handle session buffer requirement
git bisect bad 6c59b6c8a0be15fa1db3d07ffcad481aa507f8be
# bad: [581615c5d0e31e0033e3458e248c6e3646b5ab13] ALSA: info: Fix potential deadlock at disconnection
git bisect bad 581615c5d0e31e0033e3458e248c6e3646b5ab13
# bad: [af3526c44f86f56af5963e8ed6dc77fc1e76ccc5] parisc/pgtable: Do not drop upper 5 address bits of physical address
git bisect bad af3526c44f86f56af5963e8ed6dc77fc1e76ccc5
# bad: [6eddd5699c407a706d8e914e0c88934c4e1b6e27] parisc: Prevent booting 64-bit kernels on PA1.x machines
git bisect bad 6eddd5699c407a706d8e914e0c88934c4e1b6e27
# first bad commit: [6eddd5699c407a706d8e914e0c88934c4e1b6e27] parisc: Prevent booting 64-bit kernels on PA1.x machines
FWIW, the offending patch is tagged "Cc: <stable@vger.kernel.org> # v6.0+"
Guenter
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-26 18:33 ` Guenter Roeck
@ 2023-11-26 20:39 ` Helge Deller
2023-11-27 12:47 ` Greg Kroah-Hartman
0 siblings, 1 reply; 18+ messages in thread
From: Helge Deller @ 2023-11-26 20:39 UTC (permalink / raw)
To: Guenter Roeck, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, Helge Deller
* Guenter Roeck <linux@roeck-us.net>:
> On 11/25/23 08:32, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.14.331 release.
> > There are 53 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Mon, 27 Nov 2023 16:30:48 +0000.
> > Anything received after that time might be too late.
> >
>
> Building parisc64:generic-64bit_defconfig ... failed
> --------------
> Error log:
> hppa64-linux-ld: arch/parisc/kernel/head.o: in function `$iodc_panic':
> (.head.text+0x64): undefined reference to `init_stack'
> hppa64-linux-ld: (.head.text+0x68): undefined reference to `init_stack'
> make[1]: *** [Makefile:1049: vmlinux] Error 1
> make: *** [Makefile:153: sub-make] Error 2
Indeed.
Thanks for testing, Guenter!
Greg, could you please replace the patch in queue/4.14 with
the one below? It simply uses another stack start, which is ok since the
machine will stop anyway.
No changes needed for your other stable-queues. I tested 4.19 and
it's ok as-is.
Thanks!
Helge
From 29e10df694b70b4283e2d6f6852afc0ea7823e5b Mon Sep 17 00:00:00 2001
From: Helge Deller <deller@gmx.de>
Date: Fri, 10 Nov 2023 16:13:15 +0100
Subject: [PATCH] parisc: Prevent booting 64-bit kernels on PA1.x machines
commit a406b8b424fa01f244c1aab02ba186258448c36b upstream.
Bail out early with error message when trying to boot a 64-bit kernel on
32-bit machines. This fixes the previous commit to include the check for
true 64-bit kernels as well.
Patch modified for 4.14 to use __bss_stop for stack. This is OK, since
the machine will halt after printing the warning.
Signed-off-by: Helge Deller <deller@gmx.de>
Fixes: 591d2108f3abc ("parisc: Add runtime check to prevent PA2.0 kernels on PA1.x machines")
Cc: <stable@vger.kernel.org> # v6.0+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/arch/parisc/kernel/head.S b/arch/parisc/kernel/head.S
index 2f570a520586..2f552ff3a75f 100644
--- a/arch/parisc/kernel/head.S
+++ b/arch/parisc/kernel/head.S
@@ -69,9 +69,8 @@ $bss_loop:
stw,ma %arg2,4(%r1)
stw,ma %arg3,4(%r1)
-#if !defined(CONFIG_64BIT) && defined(CONFIG_PA20)
- /* This 32-bit kernel was compiled for PA2.0 CPUs. Check current CPU
- * and halt kernel if we detect a PA1.x CPU. */
+#if defined(CONFIG_PA20)
+ /* check for 64-bit capable CPU as required by current kernel */
ldi 32,%r10
mtctl %r10,%cr11
.level 2.0
@@ -84,7 +83,7 @@ $bss_loop:
$iodc_panic:
copy %arg0, %r10
copy %arg1, %r11
- load32 PA(init_stack),%sp
+ load32 PA(__bss_stop),%sp
#define MEM_CONS 0x3A0
ldw MEM_CONS+32(%r0),%arg0 // HPA
ldi ENTRY_IO_COUT,%arg1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-26 20:39 ` Helge Deller
@ 2023-11-27 12:47 ` Greg Kroah-Hartman
0 siblings, 0 replies; 18+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-27 12:47 UTC (permalink / raw)
To: Helge Deller
Cc: Guenter Roeck, stable, patches, linux-kernel, torvalds, akpm,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml
On Sun, Nov 26, 2023 at 09:39:06PM +0100, Helge Deller wrote:
> * Guenter Roeck <linux@roeck-us.net>:
> > On 11/25/23 08:32, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 4.14.331 release.
> > > There are 53 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Mon, 27 Nov 2023 16:30:48 +0000.
> > > Anything received after that time might be too late.
> > >
> >
> > Building parisc64:generic-64bit_defconfig ... failed
> > --------------
> > Error log:
> > hppa64-linux-ld: arch/parisc/kernel/head.o: in function `$iodc_panic':
> > (.head.text+0x64): undefined reference to `init_stack'
> > hppa64-linux-ld: (.head.text+0x68): undefined reference to `init_stack'
> > make[1]: *** [Makefile:1049: vmlinux] Error 1
> > make: *** [Makefile:153: sub-make] Error 2
>
> Indeed.
> Thanks for testing, Guenter!
>
> Greg, could you please replace the patch in queue/4.14 with
> the one below? It simply uses another stack start, which is ok since the
> machine will stop anyway.
>
> No changes needed for your other stable-queues. I tested 4.19 and
> it's ok as-is.
>
Now replaced, thanks.
greg k-h
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-25 16:32 [PATCH 4.14 00/53] 4.14.331-rc2 review Greg Kroah-Hartman
2023-11-25 20:10 ` Pavel Machek
2023-11-26 18:33 ` Guenter Roeck
@ 2023-11-27 5:47 ` Harshit Mogalapalli
2023-11-27 14:33 ` Naresh Kamboju
` (3 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Harshit Mogalapalli @ 2023-11-27 5:47 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, Vegard Nossum, Darren Kenny
On 25/11/23 10:02 pm, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.331 release.
> There are 53 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Mon, 27 Nov 2023 16:30:48 +0000.
> Anything received after that time might be too late.
>
No problems seen on x86_64 and aarch64 with our testing.
Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thanks,
Harshit
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.331-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> --------
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-25 16:32 [PATCH 4.14 00/53] 4.14.331-rc2 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2023-11-27 5:47 ` Harshit Mogalapalli
@ 2023-11-27 14:33 ` Naresh Kamboju
2023-11-27 20:51 ` Pavel Machek
` (2 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Naresh Kamboju @ 2023-11-27 14:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml
On Sat, 25 Nov 2023 at 22:02, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.14.331 release.
> There are 53 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Mon, 27 Nov 2023 16:30:48 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.331-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
## Build
* kernel: 4.14.331-rc2
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-4.14.y
* git commit: 39ca2c4cec46e5ef545815f62be91cba998b8927
* git describe: v4.14.330-54-g39ca2c4cec46
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.14.y/build/v4.14.330-54-g39ca2c4cec46
## Test Regressions (compared to v4.14.330)
## Metric Regressions (compared to v4.14.330)
## Test Fixes (compared to v4.14.330)
## Metric Fixes (compared to v4.14.330)
## Test result summary
total: 54577, pass: 45662, fail: 1547, skip: 7326, xfail: 42
## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 108 total, 103 passed, 5 failed
* arm64: 35 total, 31 passed, 4 failed
* i386: 21 total, 18 passed, 3 failed
* mips: 19 total, 19 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 8 total, 7 passed, 1 failed
* s390: 6 total, 5 passed, 1 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 27 total, 23 passed, 4 failed
## Test suites summary
* boot
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-user_events
* kselftest-vDSO
* kselftest-vm
* kselftest-watchdog
* kselftest-zram
* kunit
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-crypto
* ltp-cve
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-25 16:32 [PATCH 4.14 00/53] 4.14.331-rc2 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2023-11-27 14:33 ` Naresh Kamboju
@ 2023-11-27 20:51 ` Pavel Machek
2023-11-28 13:10 ` Ilpo Järvinen
2023-11-27 23:25 ` Jon Hunter
2023-11-28 2:49 ` Guenter Roeck
6 siblings, 1 reply; 18+ messages in thread
From: Pavel Machek @ 2023-11-27 20:51 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal,
ilpo.jarvinen, skhan, bhelgaas
[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]
Hi!
> This is the start of the stable review cycle for the 4.14.331 release.
> There are 53 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
> Mario Limonciello <mario.limonciello@amd.com>
> drm/amd: Fix UBSAN array-index-out-of-bounds for Polaris and Tonga
> Mario Limonciello <mario.limonciello@amd.com>
> drm/amd: Fix UBSAN array-index-out-of-bounds for SMU7
I believed that the agreement with maintarner was that these are not
suitable for stable? There's no actual bug, but UBSAN warns anyway...
> zhujun2 <zhujun2@cmss.chinamobile.com>
> selftests/efivarfs: create-read: fix a resource leak
This is wrong. It is patching userland code, there's no memory leak,
kernel closes file descriptors upon task exit.
> Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> RDMA/hfi1: Use FIELD_GET() to extract Link Width
This is a good cleanup, but not a bugfix.
> Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> atm: iphase: Do PCI error checks on own line
Just a cleanup, not sure why it was picked for stable.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-27 20:51 ` Pavel Machek
@ 2023-11-28 13:10 ` Ilpo Järvinen
2023-11-28 20:39 ` Pavel Machek
0 siblings, 1 reply; 18+ messages in thread
From: Ilpo Järvinen @ 2023-11-28 13:10 UTC (permalink / raw)
To: Pavel Machek
Cc: Greg Kroah-Hartman, stable, patches, LKML, torvalds, akpm, linux,
shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal, skhan,
bhelgaas
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On Mon, 27 Nov 2023, Pavel Machek wrote:
> Hi!
>
> > This is the start of the stable review cycle for the 4.14.331 release.
> > There are 53 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > RDMA/hfi1: Use FIELD_GET() to extract Link Width
>
> This is a good cleanup, but not a bugfix.
>
> > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > atm: iphase: Do PCI error checks on own line
>
> Just a cleanup, not sure why it was picked for stable.
Just an additional bit of information, there have been quite many cleanups
from me which have recently gotten the stable notification for some
mysterious reason. When I had tens of them in my inbox and for various
kernel versions, I immediately stopped caring to stop it from happening.
AFAIK, I've not marked those for stable inclusion so I've no idea what
got them included.
--
i.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-28 13:10 ` Ilpo Järvinen
@ 2023-11-28 20:39 ` Pavel Machek
2023-11-28 20:43 ` Greg Kroah-Hartman
2023-11-29 11:20 ` Ilpo Järvinen
0 siblings, 2 replies; 18+ messages in thread
From: Pavel Machek @ 2023-11-28 20:39 UTC (permalink / raw)
To: Ilpo Järvinen
Cc: Pavel Machek, Greg Kroah-Hartman, stable, patches, LKML, torvalds,
akpm, linux, shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal, skhan,
bhelgaas
[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]
Hi!
> > > This is the start of the stable review cycle for the 4.14.331 release.
> > > There are 53 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
>
> > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > RDMA/hfi1: Use FIELD_GET() to extract Link Width
> >
> > This is a good cleanup, but not a bugfix.
> >
> > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > atm: iphase: Do PCI error checks on own line
> >
> > Just a cleanup, not sure why it was picked for stable.
>
> Just an additional bit of information, there have been quite many cleanups
> from me which have recently gotten the stable notification for some
> mysterious reason. When I had tens of them in my inbox and for various
> kernel versions, I immediately stopped caring to stop it from happening.
>
> AFAIK, I've not marked those for stable inclusion so I've no idea what
> got them included.
Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
human oversight :-(.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-28 20:39 ` Pavel Machek
@ 2023-11-28 20:43 ` Greg Kroah-Hartman
2023-11-28 20:48 ` Pavel Machek
2023-11-29 11:20 ` Ilpo Järvinen
1 sibling, 1 reply; 18+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-28 20:43 UTC (permalink / raw)
To: Pavel Machek
Cc: Ilpo Järvinen, stable, patches, LKML, torvalds, akpm, linux,
shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal, skhan,
bhelgaas
On Tue, Nov 28, 2023 at 09:39:36PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > This is the start of the stable review cycle for the 4.14.331 release.
> > > > There are 53 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> >
> > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > RDMA/hfi1: Use FIELD_GET() to extract Link Width
> > >
> > > This is a good cleanup, but not a bugfix.
> > >
> > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > atm: iphase: Do PCI error checks on own line
> > >
> > > Just a cleanup, not sure why it was picked for stable.
> >
> > Just an additional bit of information, there have been quite many cleanups
> > from me which have recently gotten the stable notification for some
> > mysterious reason. When I had tens of them in my inbox and for various
> > kernel versions, I immediately stopped caring to stop it from happening.
> >
> > AFAIK, I've not marked those for stable inclusion so I've no idea what
> > got them included.
>
> Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
> human oversight :-(.
the autosel bot has lots of oversight.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-28 20:43 ` Greg Kroah-Hartman
@ 2023-11-28 20:48 ` Pavel Machek
2023-11-28 21:10 ` Greg Kroah-Hartman
0 siblings, 1 reply; 18+ messages in thread
From: Pavel Machek @ 2023-11-28 20:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Pavel Machek, Ilpo Järvinen, stable, patches, LKML, torvalds,
akpm, linux, shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal, skhan,
bhelgaas
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
Hi!
> > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > > RDMA/hfi1: Use FIELD_GET() to extract Link Width
> > > >
> > > > This is a good cleanup, but not a bugfix.
> > > >
> > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > > atm: iphase: Do PCI error checks on own line
> > > >
> > > > Just a cleanup, not sure why it was picked for stable.
> > >
> > > Just an additional bit of information, there have been quite many cleanups
> > > from me which have recently gotten the stable notification for some
> > > mysterious reason. When I had tens of them in my inbox and for various
> > > kernel versions, I immediately stopped caring to stop it from happening.
> > >
> > > AFAIK, I've not marked those for stable inclusion so I've no idea what
> > > got them included.
> >
> > Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
> > human oversight :-(.
>
> the autosel bot has lots of oversight.
Can you describe how that oversight works?
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-28 20:48 ` Pavel Machek
@ 2023-11-28 21:10 ` Greg Kroah-Hartman
2023-11-29 9:00 ` Pavel Machek
0 siblings, 1 reply; 18+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-28 21:10 UTC (permalink / raw)
To: Pavel Machek
Cc: Ilpo Järvinen, stable, patches, LKML, torvalds, akpm, linux,
shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal, skhan,
bhelgaas
On Tue, Nov 28, 2023 at 09:48:42PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > > > RDMA/hfi1: Use FIELD_GET() to extract Link Width
> > > > >
> > > > > This is a good cleanup, but not a bugfix.
> > > > >
> > > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > > > atm: iphase: Do PCI error checks on own line
> > > > >
> > > > > Just a cleanup, not sure why it was picked for stable.
> > > >
> > > > Just an additional bit of information, there have been quite many cleanups
> > > > from me which have recently gotten the stable notification for some
> > > > mysterious reason. When I had tens of them in my inbox and for various
> > > > kernel versions, I immediately stopped caring to stop it from happening.
> > > >
> > > > AFAIK, I've not marked those for stable inclusion so I've no idea what
> > > > got them included.
> > >
> > > Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
> > > human oversight :-(.
> >
> > the autosel bot has lots of oversight.
>
> Can you describe how that oversight works?
There have been many papers and presentations about it, no need for me
to say it all here again...
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-28 21:10 ` Greg Kroah-Hartman
@ 2023-11-29 9:00 ` Pavel Machek
2023-11-29 17:45 ` Sasha Levin
0 siblings, 1 reply; 18+ messages in thread
From: Pavel Machek @ 2023-11-29 9:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Pavel Machek, Ilpo Järvinen, stable, patches, LKML, torvalds,
akpm, linux, shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal, skhan,
bhelgaas
[-- Attachment #1: Type: text/plain, Size: 1983 bytes --]
On Tue 2023-11-28 21:10:03, Greg Kroah-Hartman wrote:
> On Tue, Nov 28, 2023 at 09:48:42PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > > > > RDMA/hfi1: Use FIELD_GET() to extract Link Width
> > > > > >
> > > > > > This is a good cleanup, but not a bugfix.
> > > > > >
> > > > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > > > > atm: iphase: Do PCI error checks on own line
> > > > > >
> > > > > > Just a cleanup, not sure why it was picked for stable.
> > > > >
> > > > > Just an additional bit of information, there have been quite many cleanups
> > > > > from me which have recently gotten the stable notification for some
> > > > > mysterious reason. When I had tens of them in my inbox and for various
> > > > > kernel versions, I immediately stopped caring to stop it from happening.
> > > > >
> > > > > AFAIK, I've not marked those for stable inclusion so I've no idea what
> > > > > got them included.
> > > >
> > > > Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
> > > > human oversight :-(.
> > >
> > > the autosel bot has lots of oversight.
> >
> > Can you describe how that oversight works?
>
> There have been many papers and presentations about it, no need for me
> to say it all here again...
Give a pointer.
And explain why AUTOSEL is full of cleanups, as noticed by Ilpo, me
and others. AFAICT Sasha does not hand-check patches picked by
AUTOSEL, simply spams the mailing lists, and hopes that maintainers
will react. And they won't, because they don't understand the
implications, and simply ignore the spam. Or they will, and Sasha
simply ignores the reply.
If the process is something else, give me a pointer to explanation.
Thanks,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-29 9:00 ` Pavel Machek
@ 2023-11-29 17:45 ` Sasha Levin
0 siblings, 0 replies; 18+ messages in thread
From: Sasha Levin @ 2023-11-29 17:45 UTC (permalink / raw)
To: Pavel Machek
Cc: Greg Kroah-Hartman, Ilpo Järvinen, stable, patches, LKML,
torvalds, akpm, linux, shuah, patches, lkft-triage, jonathanh,
f.fainelli, sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, skhan, bhelgaas
On Wed, Nov 29, 2023 at 10:00:44AM +0100, Pavel Machek wrote:
>On Tue 2023-11-28 21:10:03, Greg Kroah-Hartman wrote:
>> On Tue, Nov 28, 2023 at 09:48:42PM +0100, Pavel Machek wrote:
>> > Hi!
>> >
>> > > > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> > > > > > > RDMA/hfi1: Use FIELD_GET() to extract Link Width
>> > > > > >
>> > > > > > This is a good cleanup, but not a bugfix.
>> > > > > >
>> > > > > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> > > > > > > atm: iphase: Do PCI error checks on own line
>> > > > > >
>> > > > > > Just a cleanup, not sure why it was picked for stable.
>> > > > >
>> > > > > Just an additional bit of information, there have been quite many cleanups
>> > > > > from me which have recently gotten the stable notification for some
>> > > > > mysterious reason. When I had tens of them in my inbox and for various
>> > > > > kernel versions, I immediately stopped caring to stop it from happening.
>> > > > >
>> > > > > AFAIK, I've not marked those for stable inclusion so I've no idea what
>> > > > > got them included.
>> > > >
>> > > > Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
>> > > > human oversight :-(.
>> > >
>> > > the autosel bot has lots of oversight.
>> >
>> > Can you describe how that oversight works?
>>
>> There have been many papers and presentations about it, no need for me
>> to say it all here again...
>
>Give a pointer.
>
>And explain why AUTOSEL is full of cleanups, as noticed by Ilpo, me
>and others. AFAICT Sasha does not hand-check patches picked by
>AUTOSEL, simply spams the mailing lists, and hopes that maintainers
>will react. And they won't, because they don't understand the
Awesome feedback, thanks.
>implications, and simply ignore the spam. Or they will, and Sasha
>simply ignores the reply.
Incorrect, I just gotten tired of litigating this with *you*.
How about this: instead of complaining about work you get for free, try
doing it yourself and send us a list of patches that should go into the
-stable tree during the next merge window. Deal?
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-28 20:39 ` Pavel Machek
2023-11-28 20:43 ` Greg Kroah-Hartman
@ 2023-11-29 11:20 ` Ilpo Järvinen
1 sibling, 0 replies; 18+ messages in thread
From: Ilpo Järvinen @ 2023-11-29 11:20 UTC (permalink / raw)
To: Pavel Machek
Cc: Greg Kroah-Hartman, stable, patches, LKML, torvalds, akpm, linux,
shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
alexander.deucher, mario.limonciello, zhujun2, sashal, skhan,
bhelgaas
[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]
On Tue, 28 Nov 2023, Pavel Machek wrote:
> Hi!
>
> > > > This is the start of the stable review cycle for the 4.14.331 release.
> > > > There are 53 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> >
> > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > RDMA/hfi1: Use FIELD_GET() to extract Link Width
> > >
> > > This is a good cleanup, but not a bugfix.
> > >
> > > > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > atm: iphase: Do PCI error checks on own line
> > >
> > > Just a cleanup, not sure why it was picked for stable.
> >
> > Just an additional bit of information, there have been quite many cleanups
> > from me which have recently gotten the stable notification for some
> > mysterious reason. When I had tens of them in my inbox and for various
> > kernel versions, I immediately stopped caring to stop it from happening.
> >
> > AFAIK, I've not marked those for stable inclusion so I've no idea what
> > got them included.
>
> Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
> human oversight :-(.
I know Fixes tag will surely do it. However, the two above mentioned
patches were in series that were sent without any Fixes tags nor cc
stables for any of the patches within the same series.
--
i.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-25 16:32 [PATCH 4.14 00/53] 4.14.331-rc2 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2023-11-27 20:51 ` Pavel Machek
@ 2023-11-27 23:25 ` Jon Hunter
2023-11-28 2:49 ` Guenter Roeck
6 siblings, 0 replies; 18+ messages in thread
From: Jon Hunter @ 2023-11-27 23:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, linux-tegra,
stable
On Sat, 25 Nov 2023 16:32:43 +0000, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.331 release.
> There are 53 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Mon, 27 Nov 2023 16:30:48 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.331-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v4.14:
10 builds: 10 pass, 0 fail
16 boots: 16 pass, 0 fail
32 tests: 32 pass, 0 fail
Linux version: 4.14.331-rc2-g0957336c00be
Boards tested: tegra124-jetson-tk1, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4.14 00/53] 4.14.331-rc2 review
2023-11-25 16:32 [PATCH 4.14 00/53] 4.14.331-rc2 review Greg Kroah-Hartman
` (5 preceding siblings ...)
2023-11-27 23:25 ` Jon Hunter
@ 2023-11-28 2:49 ` Guenter Roeck
6 siblings, 0 replies; 18+ messages in thread
From: Guenter Roeck @ 2023-11-28 2:49 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml
On Sat, Nov 25, 2023 at 04:32:43PM +0000, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.331 release.
> There are 53 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Mon, 27 Nov 2023 16:30:48 +0000.
> Anything received after that time might be too late.
>
For v4.14.330-54-g0957336c00be:
Build results:
total: 139 pass: 139 fail: 0
Qemu test results:
total: 440 pass: 440 fail: 0
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
^ permalink raw reply [flat|nested] 18+ messages in thread