public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 2/2] ARM: dts: imx6q-apalis: add can power-up delay on ixora board
       [not found] <20231020153022.57858-1-andrejs.cainikovs@gmail.com>
@ 2023-10-20 15:30 ` Andrejs Cainikovs
  2023-11-27  2:52   ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Andrejs Cainikovs @ 2023-10-20 15:30 UTC (permalink / raw)
  To: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Andrejs Cainikovs, stable

From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>

Newer variants of Ixora boards require a power-up delay when powering up
the CAN transceiver of up to 1ms.

Cc: stable@vger.kernel.org
Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
---
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
index 717decda0ceb..3ac7a4501620 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
@@ -76,6 +76,7 @@ reg_can1_supply: regulator-can1-supply {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_enable_can1_power>;
 		regulator-name = "can1_supply";
+		startup-delay-us = <1000>;
 	};
 
 	reg_can2_supply: regulator-can2-supply {
@@ -85,6 +86,7 @@ reg_can2_supply: regulator-can2-supply {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_enable_can2_power>;
 		regulator-name = "can2_supply";
+		startup-delay-us = <1000>;
 	};
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 2/2] ARM: dts: imx6q-apalis: add can power-up delay on ixora board
  2023-10-20 15:30 ` [PATCH v1 2/2] ARM: dts: imx6q-apalis: add can power-up delay on ixora board Andrejs Cainikovs
@ 2023-11-27  2:52   ` Shawn Guo
  2023-11-27 10:13     ` Francesco Dolcini
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2023-11-27  2:52 UTC (permalink / raw)
  To: Andrejs Cainikovs
  Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-arm-kernel, linux-kernel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
	Andrejs Cainikovs, stable

On Fri, Oct 20, 2023 at 05:30:22PM +0200, Andrejs Cainikovs wrote:
> From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
> 
> Newer variants of Ixora boards require a power-up delay when powering up
> the CAN transceiver of up to 1ms.
> 
> Cc: stable@vger.kernel.org

Why is only the iMX6 change required for stable?

Shawn

> Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
> index 717decda0ceb..3ac7a4501620 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
> @@ -76,6 +76,7 @@ reg_can1_supply: regulator-can1-supply {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_enable_can1_power>;
>  		regulator-name = "can1_supply";
> +		startup-delay-us = <1000>;
>  	};
>  
>  	reg_can2_supply: regulator-can2-supply {
> @@ -85,6 +86,7 @@ reg_can2_supply: regulator-can2-supply {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_enable_can2_power>;
>  		regulator-name = "can2_supply";
> +		startup-delay-us = <1000>;
>  	};
>  };
>  
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 2/2] ARM: dts: imx6q-apalis: add can power-up delay on ixora board
  2023-11-27  2:52   ` Shawn Guo
@ 2023-11-27 10:13     ` Francesco Dolcini
  0 siblings, 0 replies; 3+ messages in thread
From: Francesco Dolcini @ 2023-11-27 10:13 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Andrejs Cainikovs, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
	Andrejs Cainikovs, stable

On Mon, Nov 27, 2023 at 10:52:18AM +0800, Shawn Guo wrote:
> On Fri, Oct 20, 2023 at 05:30:22PM +0200, Andrejs Cainikovs wrote:
> > From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
> > 
> > Newer variants of Ixora boards require a power-up delay when powering up
> > the CAN transceiver of up to 1ms.
> > 
> > Cc: stable@vger.kernel.org
> 
> Why is only the iMX6 change required for stable?

From what I know currently apalis-imx8 is not yet used in products
with a mainline kernel therefore the assumption that the backporting
would add very small value, however maybe is better to just backport
both to stable.

Francesco


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-27 10:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20231020153022.57858-1-andrejs.cainikovs@gmail.com>
2023-10-20 15:30 ` [PATCH v1 2/2] ARM: dts: imx6q-apalis: add can power-up delay on ixora board Andrejs Cainikovs
2023-11-27  2:52   ` Shawn Guo
2023-11-27 10:13     ` Francesco Dolcini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox