From: Zack Rusin <zack@kde.org>
To: linux-kernel@vger.kernel.org
Cc: Zack Rusin <zackr@vmware.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
Arnd Bergmann <arnd@arndb.de>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Raul Rangel <rrangel@chromium.org>,
linux-input@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH] input/vmmouse: Fix device name copies
Date: Mon, 27 Nov 2023 15:42:06 -0500 [thread overview]
Message-ID: <20231127204206.3593559-1-zack@kde.org> (raw)
From: Zack Rusin <zackr@vmware.com>
Make sure vmmouse_data::phys can hold serio::phys (which is 32 bytes)
plus an extra string, extend it to 64.
Fixes gcc13 warnings:
drivers/input/mouse/vmmouse.c: In function ‘vmmouse_init’:
drivers/input/mouse/vmmouse.c:455:53: warning: ‘/input1’ directive output may be truncated writing 7 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
455 | snprintf(priv->phys, sizeof(priv->phys), "%s/input1",
| ^~~~~~~
drivers/input/mouse/vmmouse.c:455:9: note: ‘snprintf’ output between 8 and 39 bytes into a destination of size 32
455 | snprintf(priv->phys, sizeof(priv->phys), "%s/input1",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
456 | psmouse->ps2dev.serio->phys);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Zack Rusin <zackr@vmware.com>
Fixes: 8b8be51b4fd3 ("Input: add vmmouse driver")
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Raul Rangel <rrangel@chromium.org>
Cc: linux-input@vger.kernel.org
Cc: <stable@vger.kernel.org> # v4.1+
---
drivers/input/mouse/vmmouse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/vmmouse.c b/drivers/input/mouse/vmmouse.c
index ea9eff7c8099..7248cada4c8c 100644
--- a/drivers/input/mouse/vmmouse.c
+++ b/drivers/input/mouse/vmmouse.c
@@ -72,7 +72,7 @@
*/
struct vmmouse_data {
struct input_dev *abs_dev;
- char phys[32];
+ char phys[64];
char dev_name[128];
};
--
2.39.2
next reply other threads:[~2023-11-27 20:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 20:42 Zack Rusin [this message]
2023-12-03 18:41 ` [PATCH] input/vmmouse: Fix device name copies Dmitry Torokhov
2023-12-03 20:50 ` Arnd Bergmann
2023-12-03 21:14 ` David Laight
2023-12-08 23:45 ` Dmitry Torokhov
2024-01-04 5:06 ` [PATCH v2] " Zack Rusin
2024-01-04 5:07 ` Zack Rusin
2024-01-04 16:03 ` kernel test robot
2024-01-04 21:29 ` Zack Rusin
2024-01-04 19:23 ` kernel test robot
2024-01-04 22:01 ` kernel test robot
2024-01-04 22:57 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127204206.3593559-1-zack@kde.org \
--to=zack@kde.org \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=rrangel@chromium.org \
--cc=stable@vger.kernel.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox