public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	Sasha Levin <sashal@kernel.org>,
	tj@kernel.org, josef@toxicpanda.com, cgroups@vger.kernel.org,
	linux-block@vger.kernel.org
Subject: [PATCH AUTOSEL 5.15 04/15] blk-cgroup: bypass blkcg_deactivate_policy after destroying
Date: Tue, 28 Nov 2023 16:08:25 -0500	[thread overview]
Message-ID: <20231128210843.876493-4-sashal@kernel.org> (raw)
In-Reply-To: <20231128210843.876493-1-sashal@kernel.org>

From: Ming Lei <ming.lei@redhat.com>

[ Upstream commit e63a57303599b17290cd8bc48e6f20b24289a8bc ]

blkcg_deactivate_policy() can be called after blkg_destroy_all()
returns, and it isn't necessary since blkg_destroy_all has covered
policy deactivation.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20231117023527.3188627-4-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 block/blk-cgroup.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 3ee4c1217b636..fd81a73708645 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -425,6 +425,7 @@ static void blkg_destroy_all(struct request_queue *q)
 {
 	struct blkcg_gq *blkg, *n;
 	int count = BLKG_DESTROY_BATCH_SIZE;
+	int i;
 
 restart:
 	spin_lock_irq(&q->queue_lock);
@@ -447,6 +448,18 @@ static void blkg_destroy_all(struct request_queue *q)
 		}
 	}
 
+	/*
+	 * Mark policy deactivated since policy offline has been done, and
+	 * the free is scheduled, so future blkcg_deactivate_policy() can
+	 * be bypassed
+	 */
+	for (i = 0; i < BLKCG_MAX_POLS; i++) {
+		struct blkcg_policy *pol = blkcg_policy[i];
+
+		if (pol)
+			__clear_bit(pol->plid, q->blkcg_pols);
+	}
+
 	q->root_blkg = NULL;
 	spin_unlock_irq(&q->queue_lock);
 }
-- 
2.42.0


  parent reply	other threads:[~2023-11-28 21:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 21:08 [PATCH AUTOSEL 5.15 01/15] usb: aqc111: check packet for fixup for true limit Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 02/15] stmmac: dwmac-loongson: Add architecture dependency Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 03/15] blk-throttle: fix lockdep warning of "cgroup_mutex or RCU read lock required!" Sasha Levin
2023-11-28 21:08 ` Sasha Levin [this message]
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 05/15] bcache: avoid oversize memory allocation by small stripe_size Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 06/15] bcache: remove redundant assignment to variable cur_idx Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 07/15] bcache: add code comments for bch_btree_node_get() and __bch_btree_node_alloc() Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 08/15] bcache: avoid NULL checking to c->root in run_cache_set() Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 09/15] platform/x86: intel_telemetry: Fix kernel doc descriptions Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 10/15] HID: glorious: fix Glorious Model I HID report Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 11/15] HID: add ALWAYS_POLL quirk for Apple kb Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 12/15] HID: hid-asus: reset the backlight brightness level on resume Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 13/15] HID: multitouch: Add quirk for HONOR GLO-GXXX touchpad Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 14/15] asm-generic: qspinlock: fix queued_spin_value_unlocked() implementation Sasha Levin
2023-11-28 21:08 ` [PATCH AUTOSEL 5.15 15/15] net: usb: qmi_wwan: claim interface 4 for ZTE MF290 Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128210843.876493-4-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox