From: Greg KH <greg@kroah.com>
To: Malcolm Hart <malcolm@5harts.com>
Cc: Mark Brown <broonie@kernel.org>,
Sven Frotscher <sven.frotscher@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] sound: soc: amd: yc: Fix non-functional mic on ASUS E1504FA
Date: Tue, 28 Nov 2023 08:08:48 +0000 [thread overview]
Message-ID: <2023112834-luckless-deport-2fce@gregkh> (raw)
In-Reply-To: <871qcbszh0.fsf@5harts.com>
On Mon, Nov 27, 2023 at 08:36:00PM +0000, Malcolm Hart wrote:
>
>
> This patch adds ASUSTeK COMPUTER INC "E1504FA" to the quirks file acp6x-mach.c
> to enable microphone array on ASUS Vivobook GO 15.
> I have this laptop and can confirm that the patch succeeds in enabling the
> microphone array.
>
> Signed-off-by: Malcolm Hart <malcolm@5harts.com>
> Cc: stable@vger.kernel.org
> ---
> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 15a864dcd7bd3a..3babb17a56bb55 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"),
> }
> },
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2023-11-28 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 19:42 [PATCH] sound: soc: amd: yc: Fix non-functional mic on ASUS E1504FA Malcolm Hart
2023-11-27 20:01 ` kernel test robot
2023-11-27 20:36 ` Malcolm Hart
2023-11-28 8:08 ` Greg KH [this message]
2023-11-28 17:47 ` Mark Brown
2023-11-28 14:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112834-luckless-deport-2fce@gregkh \
--to=greg@kroah.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malcolm@5harts.com \
--cc=stable@vger.kernel.org \
--cc=sven.frotscher@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox