From: Greg KH <gregkh@linuxfoundation.org>
To: Krister Johansen <kjlx@templeofstupid.com>
Cc: stable@vger.kernel.org, mcgrof@kernel.org
Subject: Re: [PATCH 5.15.y] proc: sysctl: prevent aliased sysctls from getting passed to init
Date: Thu, 30 Nov 2023 13:43:21 +0000 [thread overview]
Message-ID: <2023113014-confined-stillness-37e0@gregkh> (raw)
In-Reply-To: <20231130030534.GA2067@templeofstupid.com>
On Wed, Nov 29, 2023 at 07:05:34PM -0800, Krister Johansen wrote:
> commit 8001f49394e353f035306a45bcf504f06fca6355 upstream.
>
> The code that checks for unknown boot options is unaware of the sysctl
> alias facility, which maps bootparams to sysctl values. If a user sets
> an old value that has a valid alias, a message about an invalid
> parameter will be printed during boot, and the parameter will get passed
> to init. Fix by checking for the existence of aliased parameters in the
> unknown boot parameter code. If an alias exists, don't return an error
> or pass the value to init.
>
> Signed-off-by: Krister Johansen <kjlx@templeofstupid.com>
> Cc: stable@vger.kernel.org
> Fixes: 0a477e1ae21b ("kernel/sysctl: support handling command line aliases")
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> Signed-off-by: Krister Johansen <kjlx@templeofstupid.com>
> ---
> fs/proc/proc_sysctl.c | 7 +++++++
> include/linux/sysctl.h | 6 ++++++
> init/main.c | 4 ++++
> 3 files changed, 17 insertions(+)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-11-30 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 17:22 FAILED: patch "[PATCH] proc: sysctl: prevent aliased sysctls from getting passed to" failed to apply to 5.15-stable tree gregkh
2023-11-30 3:05 ` [PATCH 5.15.y] proc: sysctl: prevent aliased sysctls from getting passed to init Krister Johansen
2023-11-30 13:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023113014-confined-stillness-37e0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=kjlx@templeofstupid.com \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox