From: Greg KH <gregkh@linuxfoundation.org>
To: Francis Laniel <flaniel@linux.microsoft.com>
Cc: stable@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Christoph Hellwig <hch@lst.de>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH 5.15.y v1 1/2] kallsyms: Make kallsyms_on_each_symbol generally available
Date: Tue, 5 Dec 2023 08:58:38 +0900 [thread overview]
Message-ID: <2023120533-washtub-data-f661@gregkh> (raw)
In-Reply-To: <2709501.mvXUDI8C0e@pwmachine>
On Mon, Dec 04, 2023 at 09:19:05AM +0100, Francis Laniel wrote:
> Hi!
>
>
> Le samedi 2 décembre 2023, 00:02:58 CET Greg KH a écrit :
> > On Fri, Dec 01, 2023 at 04:19:56PM +0100, Francis Laniel wrote:
> > > From: Jiri Olsa <jolsa@kernel.org>
> > >
> > > Making kallsyms_on_each_symbol generally available, so it can be
> > > used outside CONFIG_LIVEPATCH option in following changes.
> > >
> > > Rather than adding another ifdef option let's make the function
> > > generally available (when CONFIG_KALLSYMS option is defined).
> > >
> > > Cc: Christoph Hellwig <hch@lst.de>
> > > Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > Link: https://lore.kernel.org/r/20220510122616.2652285-2-jolsa@kernel.org
> > > Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> > > ---
> > >
> > > include/linux/kallsyms.h | 7 ++++++-
> > > kernel/kallsyms.c | 2 --
> > > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > What is the git id of this commit in Linus's tree?
>
> Sorry, the commit ID is [1]:
> d721def7392a7348ffb9f3583b264239cbd3702c
Please send a new, updated series for all branches that you wish this
series to go on, and MOST IMPORTANTLY, some sort of proof that this
actually works this time...
In other words, you need to test-build this on all arches and somehow
run-time test it as well, good luck!
thanks,
greg k-h
next prev parent reply other threads:[~2023-12-04 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:19 [PATCH 5.15.y v1 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation Francis Laniel
2023-12-01 15:19 ` [PATCH 5.15.y v1 1/2] kallsyms: Make kallsyms_on_each_symbol generally available Francis Laniel
2023-12-01 23:02 ` Greg KH
2023-12-04 8:19 ` Francis Laniel
2023-12-04 23:58 ` Greg KH [this message]
2023-12-05 9:42 ` Francis Laniel
2023-12-01 15:19 ` [PATCH 5.15.y v1 2/2] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols Francis Laniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023120533-washtub-data-f661@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ast@kernel.org \
--cc=flaniel@linux.microsoft.com \
--cc=hch@lst.de \
--cc=jolsa@kernel.org \
--cc=mhiramat@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox