From: "Marek Behún" <kabel@kernel.org>
To: Sjoerd Simons <sjoerd@collabora.com>
Cc: kernel@collabora.com, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] bus: moxtet: Add spi device table
Date: Thu, 7 Dec 2023 15:43:20 +0100 [thread overview]
Message-ID: <20231207154320.4bd7d7a0@dellmb> (raw)
In-Reply-To: <20231128213536.3764212-3-sjoerd@collabora.com>
On Tue, 28 Nov 2023 22:35:05 +0100
Sjoerd Simons <sjoerd@collabora.com> wrote:
> The moxtet module fails to auto-load on. Add a SPI id table to
> allow it to do so.
>
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> Cc: stable@vger.kernel.org
>
> ---
>
> (no changes since v1)
>
> drivers/bus/moxtet.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 48c18f95660a..e384fbc6c1d9 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -830,6 +830,12 @@ static void moxtet_remove(struct spi_device *spi)
> mutex_destroy(&moxtet->lock);
> }
>
> +static const struct spi_device_id moxtet_spi_ids[] = {
> + { "moxtet" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(spi, moxtet_spi_ids);
> +
> static const struct of_device_id moxtet_dt_ids[] = {
> { .compatible = "cznic,moxtet" },
> {},
> @@ -841,6 +847,7 @@ static struct spi_driver moxtet_spi_driver = {
> .name = "moxtet",
> .of_match_table = moxtet_dt_ids,
> },
> + .id_table = moxtet_spi_ids,
> .probe = moxtet_probe,
> .remove = moxtet_remove,
> };
Reviewed-by: Marek Behún <kabel@kernel.org>
next prev parent reply other threads:[~2023-12-07 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231128213536.3764212-1-sjoerd@collabora.com>
2023-11-28 21:35 ` [PATCH v2 1/3] bus: moxtet: Mark the irq as shared Sjoerd Simons
2023-12-07 14:43 ` Marek Behún
2023-11-28 21:35 ` [PATCH v2 2/3] bus: moxtet: Add spi device table Sjoerd Simons
2023-12-07 14:43 ` Marek Behún [this message]
2023-11-28 21:35 ` [PATCH v2 3/3] arm64: dts: armada-3720-turris-mox: set irq type for RTC Sjoerd Simons
2023-12-07 14:43 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207154320.4bd7d7a0@dellmb \
--to=kabel@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sjoerd@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox