Re: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

Re: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 2481 bytes --]

Hello,

On Fri, Dec 08, 2023 at 05:08:32AM -0500, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     spi: imx: add a device specific prepare_message callback
> 
> to the 4.19-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      spi-imx-add-a-device-specific-prepare_message-callba.patch
> and it can be found in the queue-4.19 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit b19a3770ce84da3c16acc7142e754cd8ff80ad3d
> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date:   Fri Nov 30 07:47:05 2018 +0100
> 
>     spi: imx: add a device specific prepare_message callback
>     
>     [ Upstream commit e697271c4e2987b333148e16a2eb8b5b924fd40a ]
>     
>     This is just preparatory work which allows to move some initialisation
>     that currently is done in the per transfer hook .config to an earlier
>     point in time in the next few patches. There is no change in behaviour
>     introduced by this patch.
>     
>     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>     Signed-off-by: Mark Brown <broonie@kernel.org>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>

The patch alone shouldn't be needed for stable and there is no
indication that it's a dependency for another patch. Is this an
oversight?

Other than that: IMHO the subject for this type of report could be improved. Currently it's:

	Subject: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

The most important part of it is "4.19-stable", but that only appears
after character column 90 and so my MUA doesn't show it unless the
window is wider than my default setting. Maybe make this:

	Subject: for-stable-4.19: "spi: imx: add a device specific prepare_message callback"

?

Another thing I wonder about is: The mail contains

	If you, or anyone else, feels it should not be added to the
	stable tree, please let <stable@vger.kernel.org> know about it.

but it wasn't sent to stable@vger.kernel.org.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

[Sasha Levin]

On Fri, Dec 08, 2023 at 11:48:38AM +0100, Uwe Kleine-König wrote:
>Hello,
>
>On Fri, Dec 08, 2023 at 05:08:32AM -0500, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>     spi: imx: add a device specific prepare_message callback
>>
>> to the 4.19-stable tree which can be found at:
>>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>>      spi-imx-add-a-device-specific-prepare_message-callba.patch
>> and it can be found in the queue-4.19 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>>
>>
>>
>> commit b19a3770ce84da3c16acc7142e754cd8ff80ad3d
>> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Date:   Fri Nov 30 07:47:05 2018 +0100
>>
>>     spi: imx: add a device specific prepare_message callback
>>
>>     [ Upstream commit e697271c4e2987b333148e16a2eb8b5b924fd40a ]
>>
>>     This is just preparatory work which allows to move some initialisation
>>     that currently is done in the per transfer hook .config to an earlier
>>     point in time in the next few patches. There is no change in behaviour
>>     introduced by this patch.
>>
>>     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>     Signed-off-by: Mark Brown <broonie@kernel.org>
>>     Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>The patch alone shouldn't be needed for stable and there is no
>indication that it's a dependency for another patch. Is this an
>oversight?

It is, appologies. I've been traveling and my patch-shuffling-fu isn't
doing well with conference/jetlag.

This is a dependency for 00b80ac93553 ("spi: imx: mx51-ecspi: Move some
initialisation to prepare_message hook.").

>Other than that: IMHO the subject for this type of report could be improved. Currently it's:
>
>	Subject: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree
>
>The most important part of it is "4.19-stable", but that only appears
>after character column 90 and so my MUA doesn't show it unless the
>window is wider than my default setting. Maybe make this:
>
>	Subject: for-stable-4.19: "spi: imx: add a device specific prepare_message callback"
>
>?

I borrowed the format from Greg, and I'd say that if we make changes
then we should be consistent with eachother.

No objections on my end; maybe I'd even go further and try and send one
email per patch rather than one mail per patch/tree.

Or... finally drop the stable-commits mailing list altogether? Does
anyone still need this (vs. just looking at -rcs)?

Greg?

>Another thing I wonder about is: The mail contains
>
>	If you, or anyone else, feels it should not be added to the
>	stable tree, please let <stable@vger.kernel.org> know about it.
>
>but it wasn't sent to stable@vger.kernel.org.

Good point. I figured we want to reduce the spam on stable@ since you'd
see a mail about this patch in the -rc mails, and so stable@ isn't
cc'ed, but I can definitely add a reply-to header.

Thanks!

-- 
Thanks,
Sasha

Re: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

[Greg KH]

On Sat, Dec 09, 2023 at 01:34:51AM -0500, Sasha Levin wrote:
> On Fri, Dec 08, 2023 at 11:48:38AM +0100, Uwe Kleine-König wrote:
> > Hello,
> > 
> > On Fri, Dec 08, 2023 at 05:08:32AM -0500, Sasha Levin wrote:
> > > This is a note to let you know that I've just added the patch titled
> > > 
> > >     spi: imx: add a device specific prepare_message callback
> > > 
> > > to the 4.19-stable tree which can be found at:
> > >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > 
> > > The filename of the patch is:
> > >      spi-imx-add-a-device-specific-prepare_message-callba.patch
> > > and it can be found in the queue-4.19 subdirectory.
> > > 
> > > If you, or anyone else, feels it should not be added to the stable tree,
> > > please let <stable@vger.kernel.org> know about it.
> > > 
> > > 
> > > 
> > > commit b19a3770ce84da3c16acc7142e754cd8ff80ad3d
> > > Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > Date:   Fri Nov 30 07:47:05 2018 +0100
> > > 
> > >     spi: imx: add a device specific prepare_message callback
> > > 
> > >     [ Upstream commit e697271c4e2987b333148e16a2eb8b5b924fd40a ]
> > > 
> > >     This is just preparatory work which allows to move some initialisation
> > >     that currently is done in the per transfer hook .config to an earlier
> > >     point in time in the next few patches. There is no change in behaviour
> > >     introduced by this patch.
> > > 
> > >     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >     Signed-off-by: Mark Brown <broonie@kernel.org>
> > >     Signed-off-by: Sasha Levin <sashal@kernel.org>
> > 
> > The patch alone shouldn't be needed for stable and there is no
> > indication that it's a dependency for another patch. Is this an
> > oversight?
> 
> It is, appologies. I've been traveling and my patch-shuffling-fu isn't
> doing well with conference/jetlag.
> 
> This is a dependency for 00b80ac93553 ("spi: imx: mx51-ecspi: Move some
> initialisation to prepare_message hook.").
> 
> > Other than that: IMHO the subject for this type of report could be improved. Currently it's:
> > 
> > 	Subject: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree
> > 
> > The most important part of it is "4.19-stable", but that only appears
> > after character column 90 and so my MUA doesn't show it unless the
> > window is wider than my default setting. Maybe make this:
> > 
> > 	Subject: for-stable-4.19: "spi: imx: add a device specific prepare_message callback"
> > 
> > ?
> 
> I borrowed the format from Greg, and I'd say that if we make changes
> then we should be consistent with eachother.

Sure, I can change my script, but better yet, can you send a patch
against this file:
	https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/scripts/added-to-stable

> No objections on my end; maybe I'd even go further and try and send one
> email per patch rather than one mail per patch/tree.

one-per-patch isn't going to work, sorry, as I push out queues
separately.

> Or... finally drop the stable-commits mailing list altogether? Does
> anyone still need this (vs. just looking at -rcs)?
> 
> Greg?

Yes, we still need it, we want a public record of what is merged, and
that is what the mailing list archives provide.

thanks,

greg k-h