From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A3498534B; Wed, 13 Dec 2023 17:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aXMl99mb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7905CC433C7; Wed, 13 Dec 2023 17:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702489075; bh=viG7AGNHVM+j/Siqe34sl7MtKrSza3x0N/RnzU7GrTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aXMl99mb+3U6hbUTcdKvaoTXYjVfUtH/NB7jCFXl+PpYGZJZiL6tEx3PWkO5KbyU6 hOengl1NuXpCaAQ+cbxH5ERo+Hrid2EHIhLsLtu/B0C/Q0NxmMFhextD1NDC3SFAhQ 3TLE1spIGzsT2J9ZKFqhrNUbyKHv0amQBb5R96Ec= Date: Wed, 13 Dec 2023 18:37:52 +0100 From: Greg Kroah-Hartman To: Doug Anderson Cc: Pavel Machek , Guenter Roeck , grundler@chromium.org, davem@davemloft.net, stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com Subject: Re: RTL8152_INACCESSIBLE was Re: [PATCH 6.1 000/194] 6.1.68-rc1 review Message-ID: <2023121322-mortician-superman-54a9@gregkh> References: <20231211182036.606660304@linuxfoundation.org> <2023121342-wanted-overarch-84a7@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 13, 2023 at 07:16:52AM -0800, Doug Anderson wrote: > Hi, > > On Wed, Dec 13, 2023 at 12:50 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Dec 13, 2023 at 08:52:25AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > > > This is the start of the stable review cycle for the 6.1.68 release. > > > > > > There are 194 patches in this series, all will be posted as a response > > > > > > to this one. If anyone has any issues with these being applied, please > > > > > > let me know. > > > > > > > > > > > > > > > > Douglas Anderson > > > > > > r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en() > > > > > > > > > > > > Douglas Anderson > > > > > > r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1() > > > > > > > > > > > > Douglas Anderson > > > > > > r8152: Add RTL8152_INACCESSIBLE to r8156b_wait_loading_flash() > > > > > > > > > > > > Douglas Anderson > > > > > > r8152: Add RTL8152_INACCESSIBLE checks to more loops > > > > > > > > > > > > Douglas Anderson > > > > > > r8152: Rename RTL8152_UNPLUG to RTL8152_INACCESSIBLE > > > > > > > > > > Central patch that actually fixes something is: > > > > > > > > > > commit d9962b0d42029bcb40fe3c38bce06d1870fa4df4 > > > > > Author: Douglas Anderson > > > > > Date: Fri Oct 20 14:06:59 2023 -0700 > > > > > > > > > > r8152: Block future register access if register access fails > > > > > > > > > > ...but we don't have that in 6.1. So we should not need the rest, > > > > > either. > > > > > > > > > > > > > Also, the missing patch is fixed subsequently by another patch, so it can not > > > > be added on its own. > > > > > > For the record I'm trying to advocate "drop all patches listed as they > > > don't fix the bug", not "add more", as this does not meet stable > > > criteria. > > > > But the original commit here does say it fixes a bug, see the text of > > the commits listed above. So perhaps someone got this all wrong when > > they wrote the original commits that got merged into 6.7-rc? Otherwise > > this seems like they are sane to keep for now, unless the original > > author says they should be dropped, or someone who can test this driver > > says something went wrong. > > Right. The patches that "add RTL8152_INACCESSIBLE" to more loops are > bugfixes, but they're not terribly important ones to backport. While > they technically make sense even on older kernels and could > conceivably make the older kernels unload the r8152 driver a little > faster when a device is unplugged, it's not a big deal. On the first > version of the recent patches I didn't even add a "Fixes" tag for them > but I was asked to during the review process. > > The "add RTL8152_INACCESSIBLE" patches become more important with > commit d9962b0d4202 ("r8152: Block future register access if register > access fails"). Once you have that it's possible to end up in the > "INACCESSIBLE" situation in response to normal (ish) error handling > and thus you want it to be faster. > > Based on our experience in ChromeOS, commit d9962b0d4202 ("r8152: > Block future register access if register access fails") is a pretty > important fix and I would say it should be backported to stable. > Certainly we've backported it to our kernels in ChromeOS. In our case > we made things easier on ourselves by backporting pretty much all > patches to the r8152 driver. Ok, as lots of fixes seem to be needed here, do you have a list of the git ids that we should backport to bring this up to a workable state like you have in your tree? thanks, greg k-h