From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8611680595; Mon, 18 Dec 2023 12:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yjnk2a2n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D45EC433C8; Mon, 18 Dec 2023 12:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702903621; bh=fPk9nWOEQwrLDz9tsexOez9iKGfoNwqwy3zhKY2+ESQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yjnk2a2nebAwzCmPEIw1Dlo9q6+Jib7Mz5EiNb4Dbhb60PoGDU1HkMf1LIVveTEPA oCazG9tCKklfqX3Jn1d7d7weZMVUKZgovlndp2UuakFd1hKjsVqBlmNc7jr/vsKM29 bi/35fhWPFoBh9xAIDN6/krm+BdE0CznOQFI2W/6hqcnDAlHAC2Ki5y5x+QGesEZGw 5rowB98R8ziKdB8T812TfpO27rEaeACapBscFgMhyN8ygY/W7ZSAkV36iBO/E6lFrK fLk8BPNXVb37BbnSOgjkGhlTO7c5rgY+br2JQW0jy5/r8FKrdRf3WqBPruwxn90ElV J0mQZpJVysGtg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhang Yi , Jan Kara , Theodore Ts'o , Sasha Levin , jack@suse.com, linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 2/7] jbd2: correct the printing of write_flags in jbd2_write_superblock() Date: Mon, 18 Dec 2023 07:46:47 -0500 Message-ID: <20231218124656.1381949-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231218124656.1381949-1-sashal@kernel.org> References: <20231218124656.1381949-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.264 Content-Transfer-Encoding: 8bit From: Zhang Yi [ Upstream commit 85559227211020b270728104c3b89918f7af27ac ] The write_flags print in the trace of jbd2_write_superblock() is not real, so move the modification before the trace. Signed-off-by: Zhang Yi Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20231129114740.2686201-1-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/jbd2/journal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index eeebe64b7c543..81bd7b29a10b6 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -1355,9 +1355,11 @@ static int jbd2_write_superblock(journal_t *journal, int write_flags) return -EIO; } - trace_jbd2_write_superblock(journal, write_flags); if (!(journal->j_flags & JBD2_BARRIER)) write_flags &= ~(REQ_FUA | REQ_PREFLUSH); + + trace_jbd2_write_superblock(journal, write_flags); + if (buffer_write_io_error(bh)) { /* * Oh, dear. A previous attempt to write the journal -- 2.43.0