From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 866041297C5; Mon, 18 Dec 2023 12:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T3QcNoNN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 480ACC433C9; Mon, 18 Dec 2023 12:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702903657; bh=jg4pe2j16nuLVB+2t6PWwYOylMOu9N+p+EVl2Kz2PQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T3QcNoNNf6HchHE05I8IggI09bLhrAcJVPwAbGamVwBUkK2PhQpERaI9dWkAIrKyg 9AIXjczuIDPrUNpAbZwmWc+09mjdtr84+fvhps/kMmjo73122NW97PS1BdOURQ2RLV rMxiU/zB1G4PzKKEHcQPPcBW4csn3EX7+wyxHz710oOanIypHGzYpE7R1WWcYaCbh8 9R/S5zrMz94bbu7TvULCx6xxdwSbTk5mCl4AQNJVdg/qEt6ZBgxfnZbqNzzzyUrZ4P dlzOs7X2NIEg983M+RR0i44xrsxk1utLfOLNywO4fn7BNzQD5yEXb7zx14XyxZNlVz eDfCcNL69h2yA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Steven Rostedt (Google)" , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Sasha Levin , linux-trace-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 6/6] ring-buffer: Do not record in NMI if the arch does not support cmpxchg in NMI Date: Mon, 18 Dec 2023 07:47:23 -0500 Message-ID: <20231218124725.1382738-6-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231218124725.1382738-1-sashal@kernel.org> References: <20231218124725.1382738-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.333 Content-Transfer-Encoding: 8bit From: "Steven Rostedt (Google)" [ Upstream commit 712292308af2265cd9b126aedfa987f10f452a33 ] As the ring buffer recording requires cmpxchg() to work, if the architecture does not support cmpxchg in NMI, then do not do any recording within an NMI. Link: https://lore.kernel.org/linux-trace-kernel/20231213175403.6fc18540@gandalf.local.home Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Signed-off-by: Steven Rostedt (Google) Signed-off-by: Sasha Levin --- kernel/trace/ring_buffer.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index f0d4ff2db2ef0..b1acec3e4dc3b 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -2774,6 +2774,12 @@ rb_reserve_next_event(struct ring_buffer *buffer, int nr_loops = 0; u64 diff; + /* ring buffer does cmpxchg, make sure it is safe in NMI context */ + if (!IS_ENABLED(CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG) && + (unlikely(in_nmi()))) { + return NULL; + } + rb_start_commit(cpu_buffer); #ifdef CONFIG_RING_BUFFER_ALLOW_SWAP -- 2.43.0