From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C4E9129EF7; Mon, 18 Dec 2023 13:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DC32/4xZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADD29C433C8; Mon, 18 Dec 2023 13:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702907561; bh=GOQjwq5y8UHeXyvJL7EeZknWiupj0zwCNH+fwu0xGR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DC32/4xZd8zATq+ir6aBoqrgUVCN6kc2iG+jjGmiWFOvCsJ1xxYnSIsKDbB+G0rP6 usI327SbnsWX5mMAEKKKtid1ssTO3l5lOJvHTqvttw7C8Nj6p/RPUTC0oNg5Nlrakl bM/a1tDdCf9/NC7AMTjSzSGEJt5Umsn1QqyRgnKc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hyunwoo Kim , Paolo Abeni , Sasha Levin Subject: [PATCH 4.14 07/26] net/rose: Fix Use-After-Free in rose_ioctl Date: Mon, 18 Dec 2023 14:51:09 +0100 Message-ID: <20231218135040.943044322@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231218135040.665690087@linuxfoundation.org> References: <20231218135040.665690087@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hyunwoo Kim [ Upstream commit 810c38a369a0a0ce625b5c12169abce1dd9ccd53 ] Because rose_ioctl() accesses sk->sk_receive_queue without holding a sk->sk_receive_queue.lock, it can cause a race with rose_accept(). A use-after-free for skb occurs with the following flow. ``` rose_ioctl() -> skb_peek() rose_accept() -> skb_dequeue() -> kfree_skb() ``` Add sk->sk_receive_queue.lock to rose_ioctl() to fix this issue. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Hyunwoo Kim Link: https://lore.kernel.org/r/20231209100538.GA407321@v4bel-B760M-AORUS-ELITE-AX Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/rose/af_rose.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index ac2ea4ebf7c7c..04e5e01002ae0 100644 --- a/net/rose/af_rose.c +++ b/net/rose/af_rose.c @@ -1309,9 +1309,11 @@ static int rose_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) case TIOCINQ: { struct sk_buff *skb; long amount = 0L; - /* These two are safe on a single CPU system as only user tasks fiddle here */ + + spin_lock_irq(&sk->sk_receive_queue.lock); if ((skb = skb_peek(&sk->sk_receive_queue)) != NULL) amount = skb->len; + spin_unlock_irq(&sk->sk_receive_queue.lock); return put_user(amount, (unsigned int __user *) argp); } -- 2.43.0