From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD2F415AC0; Mon, 18 Dec 2023 13:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JxrOJjk+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F32EC433C8; Mon, 18 Dec 2023 13:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702907525; bh=NTi2BcO5efkDC1XP+1nMdsVrODqeTobtn0SmtleTCkk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JxrOJjk+2sVfn6LbO7ixJSPyrCEV77UY+b0GFI7nU4iY4iHxYrqeJ8+dyfH3cL7vV xQn2IMojX8yylNZarHEZ/7PNrcjKadMzIwD58sPD6UIATOOK4OQCdTC4DZ96lVwa/X doz6QSJAVnWTumq7+xCFMjc0H8mf6OLX2jiHi9Gw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guo Ren , Ingo Molnar , Waiman Long , Linus Torvalds , Sasha Levin Subject: [PATCH 4.14 19/26] asm-generic: qspinlock: fix queued_spin_value_unlocked() implementation Date: Mon, 18 Dec 2023 14:51:21 +0100 Message-ID: <20231218135041.355079547@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231218135040.665690087@linuxfoundation.org> References: <20231218135040.665690087@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linus Torvalds [ Upstream commit 125b0bb95dd6bec81b806b997a4ccb026eeecf8f ] We really don't want to do atomic_read() or anything like that, since we already have the value, not the lock. The whole point of this is that we've loaded the lock from memory, and we want to check whether the value we loaded was a locked one or not. The main use of this is the lockref code, which loads both the lock and the reference count in one atomic operation, and then works on that combined value. With the atomic_read(), the compiler would pointlessly spill the value to the stack, in order to then be able to read it back "atomically". This is the qspinlock version of commit c6f4a9002252 ("asm-generic: ticket-lock: Optimize arch_spin_value_unlocked()") which fixed this same bug for ticket locks. Cc: Guo Ren Cc: Ingo Molnar Cc: Waiman Long Link: https://lore.kernel.org/all/CAHk-=whNRv0v6kQiV5QO6DJhjH4KEL36vWQ6Re8Csrnh4zbRkQ@mail.gmail.com/ Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- include/asm-generic/qspinlock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/qspinlock.h b/include/asm-generic/qspinlock.h index 66260777d6447..c133ed3183150 100644 --- a/include/asm-generic/qspinlock.h +++ b/include/asm-generic/qspinlock.h @@ -49,7 +49,7 @@ static __always_inline int queued_spin_is_locked(struct qspinlock *lock) */ static __always_inline int queued_spin_value_unlocked(struct qspinlock lock) { - return !atomic_read(&lock.val); + return !lock.val.counter; } /** -- 2.43.0