public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Roy Luo <royluo@google.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 5.10.y] USB: gadget: core: adjust uevent timing on gadget unbind
Date: Mon, 18 Dec 2023 11:41:15 +0100	[thread overview]
Message-ID: <2023121855-uncommon-morbidity-cb4c@gregkh> (raw)
In-Reply-To: <20231215021507.2414202-1-royluo@google.com>

On Fri, Dec 15, 2023 at 02:15:07AM +0000, Roy Luo wrote:
> The KOBJ_CHANGE uevent is sent before gadget unbind is actually
> executed, resulting in inaccurate uevent emitted at incorrect timing
> (the uevent would have USB_UDC_DRIVER variable set while it would
> soon be removed).
> Move the KOBJ_CHANGE uevent to the end of the unbind function so that
> uevent is sent only after the change has been made.
> 
> Fixes: 2ccea03a8f7e ("usb: gadget: introduce UDC Class")
> Cc: stable@vger.kernel.org
> Signed-off-by: Roy Luo <royluo@google.com>
> Link: https://lore.kernel.org/r/20231128221756.2591158-1-royluo@google.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (cherry picked from commit 73ea73affe8622bdf292de898da869d441da6a9d)
> ---
>  drivers/usb/gadget/udc/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why just a 5.10.y backport?  What about 5.15.y as well?  You can't
upgrade kernels and have a regression :(

thanks,

greg k-h

  reply	other threads:[~2023-12-18 10:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 12:50 FAILED: patch "[PATCH] USB: gadget: core: adjust uevent timing on gadget unbind" failed to apply to 5.10-stable tree gregkh
2023-12-15  2:15 ` [PATCH 5.10.y] USB: gadget: core: adjust uevent timing on gadget unbind Roy Luo
2023-12-18 10:41   ` Greg Kroah-Hartman [this message]
2023-12-18 18:12     ` Roy Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023121855-uncommon-morbidity-cb4c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=royluo@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox