From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B3F3D38F for ; Wed, 20 Dec 2023 14:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eS0mA/42" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59BCBC433C8; Wed, 20 Dec 2023 14:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1703083238; bh=4N9EFqunbvVGnESNYlaOt0ocZmCcZWACLiBhSgZ9o6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eS0mA/42GNp8pNT6gasQUcdVzOJxXZ1XeG/sThy0VHPbpurdf34CRd7dyInE4p4Cg OkmoVqgqei9to5fov2Pxb0sfpUX8vjQ8RGVVrJsjUgH4Fhr30mFGrTHsIRVjpU/ljU SHMz8R8uk18HKAoZXrUUZZsIbMT+gmueJIbTpclg= Date: Wed, 20 Dec 2023 15:40:36 +0100 From: Greg KH To: Fabian Godehardt Cc: stable@vger.kernel.org Subject: Re: [4.19] please include b65ba0c362be665192381cc59e3ac3ef6f0dd1e1 Message-ID: <2023122014-defendant-breezy-5e93@gregkh> References: <20231219075640.163128-1-fg@emlix.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231219075640.163128-1-fg@emlix.com> On Tue, Dec 19, 2023 at 08:56:41AM +0100, Fabian Godehardt wrote: > Hi all, > > please include b65ba0c362be665192381cc59e3ac3ef6f0dd1e1 also on the > stable-trees up to v5.10 (i think v5.13 was the first fixed tree). > > Serial gadget on AM335X is also affected, breaks with NULL pointer > references and needs this patch. Here is the patch for the v4.19 > tree, cherry picked and manually applied from original commit > b65ba0c362be665192381cc59e3ac3ef6f0dd1e1: > > >From 483d904168b08cf1497c73516c432bde9ae94055 Mon Sep 17 00:00:00 2001 > From: Thomas Petazzoni > Date: Fri, 28 May 2021 16:04:46 +0200 > Subject: [PATCH] usb: musb: fix MUSB_QUIRK_B_DISCONNECT_99 handling > > In commit 92af4fc6ec33 ("usb: musb: Fix suspend with devices > connected for a64"), the logic to support the > MUSB_QUIRK_B_DISCONNECT_99 quirk was modified to only conditionally > schedule the musb->irq_work delayed work. > > This commit badly breaks ECM Gadget on AM335X. Indeed, with this > commit, one can observe massive packet loss: > > $ ping 192.168.0.100 > ... > 15 packets transmitted, 3 received, 80% packet loss, time 14316ms > > Reverting this commit brings back a properly functioning ECM > Gadget. An analysis of the commit seems to indicate that a mistake was > made: the previous code was not falling through into the > MUSB_QUIRK_B_INVALID_VBUS_91, but now it is, unless the condition is > taken. > > Changing the logic to be as it was before the problematic commit *and* > only conditionally scheduling musb->irq_work resolves the regression: > > $ ping 192.168.0.100 > ... > 64 packets transmitted, 64 received, 0% packet loss, time 64475ms > > Fixes: 92af4fc6ec33 ("usb: musb: Fix suspend with devices connected for a64") > Cc: stable@vger.kernel.org > Tested-by: Alexandre Belloni > Tested-by: Drew Fustini > Acked-by: Tony Lindgren > Signed-off-by: Thomas Petazzoni > Link: https://lore.kernel.org/r/20210528140446.278076-1-thomas.petazzoni@bootlin.com > Signed-off-by: Greg Kroah-Hartman > --- As you did the backport, you too need to sign off on this. Can you resend this with that properly added? thanks, greg k-h