* [PATCH 1/2] scsi: ufs: Simplify power management during async scan
[not found] <20231218225229.2542156-1-bvanassche@acm.org>
@ 2023-12-18 22:52 ` Bart Van Assche
2023-12-19 5:04 ` Can Guo
2023-12-20 14:42 ` Manivannan Sadhasivam
0 siblings, 2 replies; 5+ messages in thread
From: Bart Van Assche @ 2023-12-18 22:52 UTC (permalink / raw)
To: Martin K . Petersen
Cc: linux-scsi, Bart Van Assche, stable, James E.J. Bottomley,
Stanley Jhu, Manivannan Sadhasivam, Can Guo, Asutosh Das,
Bean Huo, Bao D. Nguyen, Arthur Simchaev
ufshcd_init() calls pm_runtime_get_sync() before it calls
async_schedule(). ufshcd_async_scan() calls pm_runtime_put_sync()
directly or indirectly from ufshcd_add_lus(). Simplify
ufshcd_async_scan() by always calling pm_runtime_put_sync() from
ufshcd_async_scan().
Cc: stable@vger.kernel.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index d6ae5d17892c..0ad8bde39cd1 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8711,7 +8711,6 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
ufs_bsg_probe(hba);
scsi_scan_host(hba->host);
- pm_runtime_put_sync(hba->dev);
out:
return ret;
@@ -8980,15 +8979,15 @@ static void ufshcd_async_scan(void *data, async_cookie_t cookie)
/* Probe and add UFS logical units */
ret = ufshcd_add_lus(hba);
+
out:
+ pm_runtime_put_sync(hba->dev);
/*
* If we failed to initialize the device or the device is not
* present, turn off the power/clocks etc.
*/
- if (ret) {
- pm_runtime_put_sync(hba->dev);
+ if (ret)
ufshcd_hba_exit(hba);
- }
}
static enum scsi_timeout_action ufshcd_eh_timed_out(struct scsi_cmnd *scmd)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: Simplify power management during async scan
2023-12-18 22:52 ` [PATCH 1/2] scsi: ufs: Simplify power management during async scan Bart Van Assche
@ 2023-12-19 5:04 ` Can Guo
2023-12-20 14:42 ` Manivannan Sadhasivam
1 sibling, 0 replies; 5+ messages in thread
From: Can Guo @ 2023-12-19 5:04 UTC (permalink / raw)
To: Bart Van Assche, Martin K . Petersen
Cc: linux-scsi, stable, James E.J. Bottomley, Stanley Jhu,
Manivannan Sadhasivam, Asutosh Das, Bean Huo, Bao D. Nguyen,
Arthur Simchaev
On 12/19/2023 6:52 AM, Bart Van Assche wrote:
> ufshcd_init() calls pm_runtime_get_sync() before it calls
> async_schedule(). ufshcd_async_scan() calls pm_runtime_put_sync()
> directly or indirectly from ufshcd_add_lus(). Simplify
> ufshcd_async_scan() by always calling pm_runtime_put_sync() from
> ufshcd_async_scan().
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ufs/core/ufshcd.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index d6ae5d17892c..0ad8bde39cd1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8711,7 +8711,6 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
>
> ufs_bsg_probe(hba);
> scsi_scan_host(hba->host);
> - pm_runtime_put_sync(hba->dev);
>
> out:
> return ret;
> @@ -8980,15 +8979,15 @@ static void ufshcd_async_scan(void *data, async_cookie_t cookie)
>
> /* Probe and add UFS logical units */
> ret = ufshcd_add_lus(hba);
> +
> out:
> + pm_runtime_put_sync(hba->dev);
> /*
> * If we failed to initialize the device or the device is not
> * present, turn off the power/clocks etc.
> */
> - if (ret) {
> - pm_runtime_put_sync(hba->dev);
> + if (ret)
> ufshcd_hba_exit(hba);
> - }
> }
>
> static enum scsi_timeout_action ufshcd_eh_timed_out(struct scsi_cmnd *scmd)
Reviewed-by: Can Guo <quic_cang@quicinc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: Simplify power management during async scan
2023-12-18 22:52 ` [PATCH 1/2] scsi: ufs: Simplify power management during async scan Bart Van Assche
2023-12-19 5:04 ` Can Guo
@ 2023-12-20 14:42 ` Manivannan Sadhasivam
2023-12-20 16:36 ` Bart Van Assche
1 sibling, 1 reply; 5+ messages in thread
From: Manivannan Sadhasivam @ 2023-12-20 14:42 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, stable, James E.J. Bottomley,
Stanley Jhu, Can Guo, Asutosh Das, Bean Huo, Bao D. Nguyen,
Arthur Simchaev
On Mon, Dec 18, 2023 at 02:52:14PM -0800, Bart Van Assche wrote:
> ufshcd_init() calls pm_runtime_get_sync() before it calls
> async_schedule(). ufshcd_async_scan() calls pm_runtime_put_sync()
> directly or indirectly from ufshcd_add_lus(). Simplify
> ufshcd_async_scan() by always calling pm_runtime_put_sync() from
> ufshcd_async_scan().
>
> Cc: stable@vger.kernel.org
No fixes tag?
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/ufs/core/ufshcd.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index d6ae5d17892c..0ad8bde39cd1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8711,7 +8711,6 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
>
> ufs_bsg_probe(hba);
> scsi_scan_host(hba->host);
> - pm_runtime_put_sync(hba->dev);
>
> out:
> return ret;
> @@ -8980,15 +8979,15 @@ static void ufshcd_async_scan(void *data, async_cookie_t cookie)
>
> /* Probe and add UFS logical units */
> ret = ufshcd_add_lus(hba);
> +
> out:
> + pm_runtime_put_sync(hba->dev);
> /*
> * If we failed to initialize the device or the device is not
> * present, turn off the power/clocks etc.
> */
> - if (ret) {
> - pm_runtime_put_sync(hba->dev);
> + if (ret)
> ufshcd_hba_exit(hba);
> - }
> }
>
> static enum scsi_timeout_action ufshcd_eh_timed_out(struct scsi_cmnd *scmd)
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: Simplify power management during async scan
2023-12-20 14:42 ` Manivannan Sadhasivam
@ 2023-12-20 16:36 ` Bart Van Assche
2023-12-20 16:59 ` Manivannan Sadhasivam
0 siblings, 1 reply; 5+ messages in thread
From: Bart Van Assche @ 2023-12-20 16:36 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Martin K . Petersen, linux-scsi, stable, James E.J. Bottomley,
Stanley Jhu, Can Guo, Asutosh Das, Bean Huo, Bao D. Nguyen,
Arthur Simchaev
On 12/20/23 06:42, Manivannan Sadhasivam wrote:
> On Mon, Dec 18, 2023 at 02:52:14PM -0800, Bart Van Assche wrote:
>> ufshcd_init() calls pm_runtime_get_sync() before it calls
>> async_schedule(). ufshcd_async_scan() calls pm_runtime_put_sync()
>> directly or indirectly from ufshcd_add_lus(). Simplify
>> ufshcd_async_scan() by always calling pm_runtime_put_sync() from
>> ufshcd_async_scan().
>>
>> Cc: stable@vger.kernel.org
>
> No fixes tag?
There is no Fixes: tag because this patch does not change the behavior of
the UFS driver. The Cc: stable tag is present because the next patch in this
series has a Fixes: tag and depends on this patch.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: Simplify power management during async scan
2023-12-20 16:36 ` Bart Van Assche
@ 2023-12-20 16:59 ` Manivannan Sadhasivam
0 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2023-12-20 16:59 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, stable, James E.J. Bottomley,
Stanley Jhu, Can Guo, Asutosh Das, Bean Huo, Bao D. Nguyen,
Arthur Simchaev
On Wed, Dec 20, 2023 at 08:36:28AM -0800, Bart Van Assche wrote:
> On 12/20/23 06:42, Manivannan Sadhasivam wrote:
> > On Mon, Dec 18, 2023 at 02:52:14PM -0800, Bart Van Assche wrote:
> > > ufshcd_init() calls pm_runtime_get_sync() before it calls
> > > async_schedule(). ufshcd_async_scan() calls pm_runtime_put_sync()
> > > directly or indirectly from ufshcd_add_lus(). Simplify
> > > ufshcd_async_scan() by always calling pm_runtime_put_sync() from
> > > ufshcd_async_scan().
> > >
> > > Cc: stable@vger.kernel.org
> >
> > No fixes tag?
>
> There is no Fixes: tag because this patch does not change the behavior of
> the UFS driver. The Cc: stable tag is present because the next patch in this
> series has a Fixes: tag and depends on this patch.
>
Ok.
- Mani
> Thanks,
>
> Bart.
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-20 16:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231218225229.2542156-1-bvanassche@acm.org>
2023-12-18 22:52 ` [PATCH 1/2] scsi: ufs: Simplify power management during async scan Bart Van Assche
2023-12-19 5:04 ` Can Guo
2023-12-20 14:42 ` Manivannan Sadhasivam
2023-12-20 16:36 ` Bart Van Assche
2023-12-20 16:59 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox