From: Anthony Brennan <a2brenna@hatguy.io>
To: stable@vger.kernel.org
Subject: [PATCH] netfs: Fix missing xas_retry() calls in xarray iteration
Date: Thu, 21 Dec 2023 19:15:22 -0500 [thread overview]
Message-ID: <20231222001522.GA32730@hatguy.io> (raw)
commit 59d0d52c30d4991ac4b329f049cc37118e00f5b0 upstream
Stops kernel from crashing when encountering an XAS retry entry. Patch modified
from upstream to work with pages instead of folios, and omits fixes to "dodgy
maths" as unrelated to fixing the crash.
Signed-off-by: Anthony Brennan <a2brenna@hatguy.io>
---
fs/netfs/read_helper.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/netfs/read_helper.c b/fs/netfs/read_helper.c
index 242f8bcb34a4..4de15555bceb 100644
--- a/fs/netfs/read_helper.c
+++ b/fs/netfs/read_helper.c
@@ -248,6 +248,9 @@ static void netfs_rreq_unmark_after_write(struct netfs_read_request *rreq,
XA_STATE(xas, &rreq->mapping->i_pages, subreq->start / PAGE_SIZE);
xas_for_each(&xas, page, (subreq->start + subreq->len - 1) / PAGE_SIZE) {
+ if(xas_retry(&xas, page))
+ continue;
+
/* We might have multiple writes from the same huge
* page, but we mustn't unlock a page more than once.
*/
@@ -403,6 +406,9 @@ static void netfs_rreq_unlock(struct netfs_read_request *rreq)
unsigned int pgend = pgpos + thp_size(page);
bool pg_failed = false;
+ if(xas_retry(&xas, page))
+ continue;
+
for (;;) {
if (!subreq) {
pg_failed = true;
--
2.30.2
next reply other threads:[~2023-12-22 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 0:15 Anthony Brennan [this message]
2023-12-22 8:50 ` [PATCH] netfs: Fix missing xas_retry() calls in xarray iteration David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222001522.GA32730@hatguy.io \
--to=a2brenna@hatguy.io \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox