From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9520A5D8F4; Tue, 26 Dec 2023 00:26:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bsq1G0M1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 608DBC433C7; Tue, 26 Dec 2023 00:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703550381; bh=l1ZGCzegb8q1Eycnu3c8u1xiEov4Q4BmErjk1cmFIOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bsq1G0M1lt5o4MPo6gSY/YgWn2uhbDiyaz9KzpQhFHS7hSWNNnW8M3+S96lXzhVaj XyTraepwhieadL3F+jVbotdHWVLYO4YyETgffoudhvdvpzLZf7ozOsGcwFHd+uH3BN yoUaJLRlr5haENyeiRhWNnpCvJyIOdmryJpEfMr9mS2uaRZ3RgRBt+4ThqE7nGIh7S EslFXRMTr6RMyWS39VYiHPeY8bXuiJAJdy7IDc4HVNldCGVgAPZPm7fzwl8WZ4R7z6 MnhHsoNpahQ36m0fZ8YkuV/SE7tP7dFEjFLcpAcd819at97Owr+ZPW9pYUMWF4sF7c zPPTmdSFEpPmg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Dmitry Torokhov , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 4/8] Input: amimouse - convert to platform remove callback returning void Date: Mon, 25 Dec 2023 19:25:47 -0500 Message-ID: <20231226002608.7089-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231226002608.7089-1-sashal@kernel.org> References: <20231226002608.7089-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.265 Content-Transfer-Encoding: 8bit From: Uwe Kleine-König [ Upstream commit 42b8ff47720258d1f6a4412e780a480c139773a0 ] The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231201133747.1099286-2-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/mouse/amimouse.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/mouse/amimouse.c b/drivers/input/mouse/amimouse.c index a50e503548323..cda0c3ff5a288 100644 --- a/drivers/input/mouse/amimouse.c +++ b/drivers/input/mouse/amimouse.c @@ -125,16 +125,15 @@ static int __init amimouse_probe(struct platform_device *pdev) return 0; } -static int __exit amimouse_remove(struct platform_device *pdev) +static void __exit amimouse_remove(struct platform_device *pdev) { struct input_dev *dev = platform_get_drvdata(pdev); input_unregister_device(dev); - return 0; } static struct platform_driver amimouse_driver = { - .remove = __exit_p(amimouse_remove), + .remove_new = __exit_p(amimouse_remove), .driver = { .name = "amiga-mouse", }, -- 2.43.0