From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732561C283; Wed, 3 Jan 2024 16:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jgGIzYhN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C788DC433C7; Wed, 3 Jan 2024 16:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1704301112; bh=yYidfdlrXT7Nar8HlUG6WFcz9rrwOYysG7BKm38Mc1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jgGIzYhNsUzA/DTKhBUTZOvnCqS4VZ3EkaFvY1I/WX4pRLlS+ins1jMO6sYPsfrBH RmLIwSbt/a/cVqcY3JytsJ1BU2UK/aPEEkKbzfg5CDpwuctrnjRdt4Qh+XBA7Tj30R N9DOQ8Fd1mvs51WE8aBfcLyHmQfm71VcjdIB9DJw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tom Rix , Sergey Senozhatsky , Namjae Jeon , Steve French , Sasha Levin Subject: [PATCH 6.1 012/100] ksmbd: remove unused is_char_allowed function Date: Wed, 3 Jan 2024 17:54:01 +0100 Message-ID: <20240103164857.974147345@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240103164856.169912722@linuxfoundation.org> References: <20240103164856.169912722@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tom Rix [ Upstream commit 2824861773eb512b37547516d81ef78108032cb2 ] clang with W=1 reports fs/ksmbd/unicode.c:122:19: error: unused function 'is_char_allowed' [-Werror,-Wunused-function] static inline int is_char_allowed(char *ch) ^ This function is not used so remove it. Signed-off-by: Tom Rix Reviewed-by: Sergey Senozhatsky Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/smb/server/unicode.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/fs/smb/server/unicode.c b/fs/smb/server/unicode.c index a0db699ddafda..9ae676906ed39 100644 --- a/fs/smb/server/unicode.c +++ b/fs/smb/server/unicode.c @@ -113,24 +113,6 @@ cifs_mapchar(char *target, const __u16 src_char, const struct nls_table *cp, goto out; } -/* - * is_char_allowed() - check for valid character - * @ch: input character to be checked - * - * Return: 1 if char is allowed, otherwise 0 - */ -static inline int is_char_allowed(char *ch) -{ - /* check for control chars, wildcards etc. */ - if (!(*ch & 0x80) && - (*ch <= 0x1f || - *ch == '?' || *ch == '"' || *ch == '<' || - *ch == '>' || *ch == '|')) - return 0; - - return 1; -} - /* * smb_from_utf16() - convert utf16le string to local charset * @to: destination buffer -- 2.43.0