Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sarthak Kukreti <sarthakkukreti@chromium.org>
Cc: stable@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>,
	Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 4.14.y] block: Don't invalidate pagecache for invalid falloc modes
Date: Fri, 5 Jan 2024 15:34:32 +0100	[thread overview]
Message-ID: <2024010520-arming-resonate-825b@gregkh> (raw)
In-Reply-To: <20240104222745.1783780-1-sarthakkukreti@chromium.org>

On Thu, Jan 04, 2024 at 02:27:45PM -0800, Sarthak Kukreti wrote:
> Only call truncate_bdev_range() if the fallocate mode is supported. This
> fixes a bug where data in the pagecache could be invalidated if the
> fallocate() was called on the block device with an invalid mode.
> 
> Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices")
> Cc: stable@vger.kernel.org
> Reported-by: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
> Link: https://lore.kernel.org/r/20231011201230.750105-1-sarthakkukreti@chromium.org
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> (cherry picked from commit 1364a3c391aedfeb32aa025303ead3d7c91cdf9d)
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
> ---
>  fs/block_dev.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

All now queued up, thanks for the backports.

greg k-h

      reply	other threads:[~2024-01-05 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15 18:23 FAILED: patch "[PATCH] block: Don't invalidate pagecache for invalid falloc modes" failed to apply to 4.14-stable tree gregkh
2024-01-04 22:27 ` [PATCH 4.14.y] block: Don't invalidate pagecache for invalid falloc modes Sarthak Kukreti
2024-01-05 14:34   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024010520-arming-resonate-825b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=sarthakkukreti@chromium.org \
    --cc=snitzer@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox