From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cengiz Can <cengiz.can@canonical.com>
Cc: Phil Sutter <phil@nwl.cc>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S . Miller" <davem@davemloft.net>,
stable@vger.kernel.org
Subject: Re: [PATCH 5.4.y] netfilter: nf_tables: Reject tables of unsupported family
Date: Sat, 13 Jan 2024 10:15:23 +0100 [thread overview]
Message-ID: <2024011304-pout-pegboard-461e@gregkh> (raw)
In-Reply-To: <20240112015436.1117482-1-cengiz.can@canonical.com>
On Fri, Jan 12, 2024 at 04:54:35AM +0300, Cengiz Can wrote:
> From: Phil Sutter <phil@nwl.cc>
>
> commit f1082dd31fe461d482d69da2a8eccfeb7bf07ac2 upstream.
>
> An nftables family is merely a hollow container, its family just a
> number and such not reliant on compile-time options other than nftables
> support itself. Add an artificial check so attempts at using a family
> the kernel can't support fail as early as possible. This helps user
> space detect kernels which lack e.g. NFPROTO_INET.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Cengiz Can <cengiz.can@canonical.com>
> ---
> net/netfilter/nf_tables_api.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
Any specific reason you sent this to us for inclusion _AFTER_ you posted
to oss-security, notifying the world of the issue?
Anyway, I have queued them up already from that report, and just now got
to these patches in my queue, making me a little bit less grumpy, but
not a lot. Please be more considerate next time.
greg k-h
prev parent reply other threads:[~2024-01-13 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 1:54 [PATCH 5.4.y] netfilter: nf_tables: Reject tables of unsupported family Cengiz Can
2024-01-12 1:54 ` [PATCH 5.10.y] " Cengiz Can
2024-01-12 1:54 ` [PATCH 5.15.y] " Cengiz Can
2024-01-13 9:15 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024011304-pout-pegboard-461e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cengiz.can@canonical.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox