From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D8A725639; Tue, 16 Jan 2024 00:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EGFot6Gs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A6E6C433C7; Tue, 16 Jan 2024 00:15:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705364120; bh=xAoHXO3uWQRqVS8UjR6OCBZxDObvScfNeQWR1SyE+x8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EGFot6GsRMYpsm11C+gVKzAc2P+QAFD31K7tQyo64kR+JU6QtYHoRYZvSxSyltEU3 IBEzeR5kr4fdCeRxVhHCtoTWXYviFqj7Ua6NZhtLcX+Gf/2b4o+mvHSdBSDT7BnYnC gY+zaEnBo07Nv8k1DTq9YKIYt4RhnYGd/FplecYxN1CmBkPp24jlEEBQ+QUWggrS1Q f0XQFJ229qcylXhRIfqemYRPGym2Lmg5Sa1Et1OP0b0VCgmOQosujyGXlnhwROjLYK plbew1WaIc7Ap4QugjZ7uVOf99hY6KjXg7HN/BkATQw2xUGyAEVosnHuvohjiPoHus wLeqe2Ru72NPw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yuluo Qiu , Celeste Liu , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 4/7] ACPI: video: Add quirk for the Colorful X15 AT 23 Laptop Date: Mon, 15 Jan 2024 19:15:09 -0500 Message-ID: <20240116001514.214199-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116001514.214199-1-sashal@kernel.org> References: <20240116001514.214199-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.267 Content-Transfer-Encoding: 8bit From: Yuluo Qiu [ Upstream commit 143176a46bdd3bfbe9ba2462bf94458e80d65ebf ] The Colorful X15 AT 23 ACPI video-bus device report spurious ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE events being reported to userspace (and causing trouble there) when an external screen plugged in. Add a quirk setting the report_key_events mask to REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE events will be ignored, while still reporting brightness up/down hotkey-presses to userspace normally. Signed-off-by: Yuluo Qiu Co-developed-by: Celeste Liu Signed-off-by: Celeste Liu Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpi_video.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index bf18efd49a25..d86a1a45b688 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -568,6 +568,15 @@ static const struct dmi_system_id video_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"), }, }, + { + .callback = video_set_report_key_events, + .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS), + .ident = "COLORFUL X15 AT 23", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "COLORFUL"), + DMI_MATCH(DMI_PRODUCT_NAME, "X15 AT 23"), + }, + }, /* * Some machines change the brightness themselves when a brightness * hotkey gets pressed, despite us telling them not to. In this case -- 2.43.0