From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Jia Jie Ho <jiajie.ho@starfivetech.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Sasha Levin <sashal@kernel.org>,
william.qiu@starfivetech.com, davem@davemloft.net,
linux-crypto@vger.kernel.org
Subject: [PATCH AUTOSEL 6.7 11/19] crypto: starfive - Fix dev_err_probe return error
Date: Mon, 15 Jan 2024 19:22:47 -0500 [thread overview]
Message-ID: <20240116002311.214705-11-sashal@kernel.org> (raw)
In-Reply-To: <20240116002311.214705-1-sashal@kernel.org>
From: Jia Jie Ho <jiajie.ho@starfivetech.com>
[ Upstream commit 8517c34e87025b3f74f3c07813d493828f369598 ]
Current dev_err_probe will return 0 instead of proper error code if
driver failed to get irq number. Fix the return code.
Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/crypto/starfive/jh7110-cryp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/starfive/jh7110-cryp.c b/drivers/crypto/starfive/jh7110-cryp.c
index 08e974e0dd12..f6601f9d3aff 100644
--- a/drivers/crypto/starfive/jh7110-cryp.c
+++ b/drivers/crypto/starfive/jh7110-cryp.c
@@ -168,7 +168,7 @@ static int starfive_cryp_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq, starfive_cryp_irq, 0, pdev->name,
(void *)cryp);
if (ret)
- return dev_err_probe(&pdev->dev, irq,
+ return dev_err_probe(&pdev->dev, ret,
"Failed to register interrupt handler\n");
clk_prepare_enable(cryp->hclk);
--
2.43.0
next prev parent reply other threads:[~2024-01-16 0:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 0:22 [PATCH AUTOSEL 6.7 01/19] FS:JFS:UBSAN:array-index-out-of-bounds in dbAdjTree Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 02/19] UBSAN: array-index-out-of-bounds in dtSplitRoot Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 03/19] jfs: fix slab-out-of-bounds Read in dtSearch Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 04/19] jfs: fix array-index-out-of-bounds in dbAdjTree Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 05/19] jfs: fix uaf in jfs_evict_inode Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 06/19] jfs: fix shift-out-of-bounds in dbJoin Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 07/19] hwrng: starfive - Fix dev_err_probe return error Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 08/19] crypto: p10-aes-gcm - Avoid -Wstringop-overflow warnings Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 09/19] pstore/ram: Fix crash when setting number of cpus to an odd number Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 10/19] erofs: fix up compacted indexes for block size < 4096 Sasha Levin
2024-01-16 0:22 ` Sasha Levin [this message]
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 12/19] crypto: octeontx2 - Fix cptvf driver cleanup Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 13/19] erofs: fix ztailpacking for subpage compressed blocks Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 14/19] crypto: stm32/crc32 - fix parsing list of devices Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 15/19] afs: fix the usage of read_seqbegin_or_lock() in afs_lookup_volume_rcu() Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 16/19] afs: fix the usage of read_seqbegin_or_lock() in afs_find_server*() Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 17/19] rxrpc_find_service_conn_rcu: fix the usage of read_seqbegin_or_lock() Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 18/19] gfs2: Refcounting fix in gfs2_thaw_super Sasha Levin
2024-01-16 0:22 ` [PATCH AUTOSEL 6.7 19/19] jfs: fix array-index-out-of-bounds in diNewExt Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116002311.214705-11-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jiajie.ho@starfivetech.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox