public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Gao Xiang <hsiangkao@linux.alibaba.com>,
	Chao Yu <chao@kernel.org>, Yue Hu <huyue2@coolpad.com>,
	Sasha Levin <sashal@kernel.org>,
	xiang@kernel.org, linux-erofs@lists.ozlabs.org
Subject: [PATCH AUTOSEL 6.7 13/19] erofs: fix ztailpacking for subpage compressed blocks
Date: Mon, 15 Jan 2024 19:22:49 -0500	[thread overview]
Message-ID: <20240116002311.214705-13-sashal@kernel.org> (raw)
In-Reply-To: <20240116002311.214705-1-sashal@kernel.org>

From: Gao Xiang <hsiangkao@linux.alibaba.com>

[ Upstream commit e5aba911dee5e20fa82efbe13e0af8f38ea459e7 ]

`pageofs_in` should be the compressed data offset of the page rather
than of the block.

Acked-by: Chao Yu <chao@kernel.org>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20231214161337.753049-1-hsiangkao@linux.alibaba.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/erofs/zdata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index a7e6847f6f8f..c9ae96467d98 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -815,7 +815,6 @@ static int z_erofs_register_pcluster(struct z_erofs_decompress_frontend *fe)
 
 	if (ztailpacking) {
 		pcl->obj.index = 0;	/* which indicates ztailpacking */
-		pcl->pageofs_in = erofs_blkoff(fe->inode->i_sb, map->m_pa);
 		pcl->tailpacking_size = map->m_plen;
 	} else {
 		pcl->obj.index = map->m_pa >> PAGE_SHIFT;
@@ -893,6 +892,7 @@ static int z_erofs_pcluster_begin(struct z_erofs_decompress_frontend *fe)
 		}
 		get_page(map->buf.page);
 		WRITE_ONCE(fe->pcl->compressed_bvecs[0].page, map->buf.page);
+		fe->pcl->pageofs_in = map->m_pa & ~PAGE_MASK;
 		fe->mode = Z_EROFS_PCLUSTER_FOLLOWED_NOINPLACE;
 	}
 	/* file-backed inplace I/O pages are traversed in reverse order */
-- 
2.43.0


  parent reply	other threads:[~2024-01-16  0:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  0:22 [PATCH AUTOSEL 6.7 01/19] FS:JFS:UBSAN:array-index-out-of-bounds in dbAdjTree Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 02/19] UBSAN: array-index-out-of-bounds in dtSplitRoot Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 03/19] jfs: fix slab-out-of-bounds Read in dtSearch Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 04/19] jfs: fix array-index-out-of-bounds in dbAdjTree Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 05/19] jfs: fix uaf in jfs_evict_inode Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 06/19] jfs: fix shift-out-of-bounds in dbJoin Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 07/19] hwrng: starfive - Fix dev_err_probe return error Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 08/19] crypto: p10-aes-gcm - Avoid -Wstringop-overflow warnings Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 09/19] pstore/ram: Fix crash when setting number of cpus to an odd number Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 10/19] erofs: fix up compacted indexes for block size < 4096 Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 11/19] crypto: starfive - Fix dev_err_probe return error Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 12/19] crypto: octeontx2 - Fix cptvf driver cleanup Sasha Levin
2024-01-16  0:22 ` Sasha Levin [this message]
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 14/19] crypto: stm32/crc32 - fix parsing list of devices Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 15/19] afs: fix the usage of read_seqbegin_or_lock() in afs_lookup_volume_rcu() Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 16/19] afs: fix the usage of read_seqbegin_or_lock() in afs_find_server*() Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 17/19] rxrpc_find_service_conn_rcu: fix the usage of read_seqbegin_or_lock() Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 18/19] gfs2: Refcounting fix in gfs2_thaw_super Sasha Levin
2024-01-16  0:22 ` [PATCH AUTOSEL 6.7 19/19] jfs: fix array-index-out-of-bounds in diNewExt Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116002311.214705-13-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=chao@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=huyue2@coolpad.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox