From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E444C11720; Tue, 16 Jan 2024 00:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OuzT5DOW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCC26C43394; Tue, 16 Jan 2024 00:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705364609; bh=1/jfaulafBo8iXr07XveIUg6jnz8lgY0whQgdlchiiU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OuzT5DOWChe+HavDefpFdem/sx9eywKdPuNLT1z13NsyS13soZ6G23oDyFTNhgkVr Hn2zOqwKOOhFzNxpqS9RxKThLv2mD8vrelffMOuEYpn2owosAYuj+3JNx2BugRssvj BMFa8l4hsiFADQY7U/5BJ/cKAlqMy42Kb0ZnAlJ3OMgyQflccX9xmmqgHOERWd4Snw UjCPHxRE7Mz6FszqT3UtNZrSd4PPRxUcEq1ZnIPgbRj98N+VCO/eN3AnyIqoOr1UQt 2FEs1AyShnYbHuKHghE/1ptzC/bHdNgS4ul2eoZx/Wi7PAKceW2E37kCi5Zup+rt43 YZXEKPSUn3mvw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia Jie Ho , kernel test robot , Dan Carpenter , Herbert Xu , Sasha Levin , olivia@selenic.com, linux-crypto@vger.kernel.org Subject: [PATCH AUTOSEL 6.7 07/19] hwrng: starfive - Fix dev_err_probe return error Date: Mon, 15 Jan 2024 19:22:43 -0500 Message-ID: <20240116002311.214705-7-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116002311.214705-1-sashal@kernel.org> References: <20240116002311.214705-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.7 Content-Transfer-Encoding: 8bit From: Jia Jie Ho [ Upstream commit 2d37b3649c412b3bcecfea932cb677f7a5775b15 ] Current dev_err_probe will return 0 instead of proper error code if driver failed to get irq number. Fix the return err code. Signed-off-by: Jia Jie Ho Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202311160649.3GhKCfhd-lkp@intel.com/ Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/char/hw_random/jh7110-trng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/jh7110-trng.c b/drivers/char/hw_random/jh7110-trng.c index 38474d48a25e..b1f94e3c0c6a 100644 --- a/drivers/char/hw_random/jh7110-trng.c +++ b/drivers/char/hw_random/jh7110-trng.c @@ -300,7 +300,7 @@ static int starfive_trng_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq, starfive_trng_irq, 0, pdev->name, (void *)trng); if (ret) - return dev_err_probe(&pdev->dev, irq, + return dev_err_probe(&pdev->dev, ret, "Failed to register interrupt handler\n"); trng->hclk = devm_clk_get(&pdev->dev, "hclk"); -- 2.43.0