public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Manas Ghandat <ghandatmanas@gmail.com>,
	syzbot+411debe54d318eaed386@syzkaller.appspotmail.com,
	Dave Kleikamp <dave.kleikamp@oracle.com>,
	Sasha Levin <sashal@kernel.org>,
	shaggy@kernel.org, juntong.deng@outlook.com,
	yogi.kernel@gmail.com, wonguk.lee1023@gmail.com, code@siddh.me,
	andrew.kanner@gmail.com, osmtendev@gmail.com,
	jfs-discussion@lists.sourceforge.net
Subject: [PATCH AUTOSEL 6.1 06/14] jfs: fix shift-out-of-bounds in dbJoin
Date: Mon, 15 Jan 2024 19:24:48 -0500	[thread overview]
Message-ID: <20240116002512.215607-6-sashal@kernel.org> (raw)
In-Reply-To: <20240116002512.215607-1-sashal@kernel.org>

From: Manas Ghandat <ghandatmanas@gmail.com>

[ Upstream commit cca974daeb6c43ea971f8ceff5a7080d7d49ee30 ]

Currently while joining the leaf in a buddy system there is shift out
of bound error in calculation of BUDSIZE. Added the required check
to the BUDSIZE and fixed the documentation as well.

Reported-by: syzbot+411debe54d318eaed386@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=411debe54d318eaed386
Signed-off-by: Manas Ghandat <ghandatmanas@gmail.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/jfs/jfs_dmap.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c
index 4462274e325a..8d064c9e9605 100644
--- a/fs/jfs/jfs_dmap.c
+++ b/fs/jfs/jfs_dmap.c
@@ -2763,7 +2763,9 @@ static int dbBackSplit(dmtree_t *tp, int leafno, bool is_ctl)
  *	leafno	- the number of the leaf to be updated.
  *	newval	- the new value for the leaf.
  *
- * RETURN VALUES: none
+ * RETURN VALUES:
+ *  0		- success
+ *	-EIO	- i/o error
  */
 static int dbJoin(dmtree_t *tp, int leafno, int newval, bool is_ctl)
 {
@@ -2790,6 +2792,10 @@ static int dbJoin(dmtree_t *tp, int leafno, int newval, bool is_ctl)
 		 * get the buddy size (number of words covered) of
 		 * the new value.
 		 */
+
+		if ((newval - tp->dmt_budmin) > BUDMIN)
+			return -EIO;
+
 		budsz = BUDSIZE(newval, tp->dmt_budmin);
 
 		/* try to join.
-- 
2.43.0


  parent reply	other threads:[~2024-01-16  0:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  0:24 [PATCH AUTOSEL 6.1 01/14] FS:JFS:UBSAN:array-index-out-of-bounds in dbAdjTree Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 02/14] UBSAN: array-index-out-of-bounds in dtSplitRoot Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 03/14] jfs: fix slab-out-of-bounds Read in dtSearch Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 04/14] jfs: fix array-index-out-of-bounds in dbAdjTree Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 05/14] jfs: fix uaf in jfs_evict_inode Sasha Levin
2024-01-16  0:24 ` Sasha Levin [this message]
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 07/14] pstore/ram: Fix crash when setting number of cpus to an odd number Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 08/14] crypto: octeontx2 - Fix cptvf driver cleanup Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 09/14] erofs: fix ztailpacking for subpage compressed blocks Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 10/14] crypto: stm32/crc32 - fix parsing list of devices Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 11/14] afs: fix the usage of read_seqbegin_or_lock() in afs_lookup_volume_rcu() Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 12/14] afs: fix the usage of read_seqbegin_or_lock() in afs_find_server*() Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 13/14] rxrpc_find_service_conn_rcu: fix the usage of read_seqbegin_or_lock() Sasha Levin
2024-01-16  0:24 ` [PATCH AUTOSEL 6.1 14/14] jfs: fix array-index-out-of-bounds in diNewExt Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116002512.215607-6-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=andrew.kanner@gmail.com \
    --cc=code@siddh.me \
    --cc=dave.kleikamp@oracle.com \
    --cc=ghandatmanas@gmail.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=juntong.deng@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osmtendev@gmail.com \
    --cc=shaggy@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+411debe54d318eaed386@syzkaller.appspotmail.com \
    --cc=wonguk.lee1023@gmail.com \
    --cc=yogi.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox