public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Sasha Levin <sashal@kernel.org>,
	gor@linux.ibm.com, imbrenda@linux.ibm.com,
	linux-s390@vger.kernel.org
Subject: [PATCH AUTOSEL 6.7 01/21] s390/boot: always align vmalloc area on segment boundary
Date: Mon, 15 Jan 2024 20:03:38 -0500	[thread overview]
Message-ID: <20240116010422.217925-1-sashal@kernel.org> (raw)

From: Alexander Gordeev <agordeev@linux.ibm.com>

[ Upstream commit 65f8780e2d70257200547b5a7654974aa7c37ce1 ]

The size of vmalloc area depends from various factors
on boot and could be set to:

1. Default size as determined by VMALLOC_DEFAULT_SIZE macro;
2. One half of the virtual address space not occupied by
   modules and fixed mappings;
3. The size provided by user with vmalloc= kernel command
   line parameter;

In cases [1] and [2] the vmalloc area base address is aligned
on Region3 table type boundary, while in case [3] in might get
aligned on page boundary.

Limit the waste of page tables and always align vmalloc area
size and base address on segment boundary.

Acked-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/s390/boot/ipl_parm.c | 2 +-
 arch/s390/boot/startup.c  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/s390/boot/ipl_parm.c b/arch/s390/boot/ipl_parm.c
index 2ab4872fbee1..b24de9aabf7d 100644
--- a/arch/s390/boot/ipl_parm.c
+++ b/arch/s390/boot/ipl_parm.c
@@ -274,7 +274,7 @@ void parse_boot_command_line(void)
 			memory_limit = round_down(memparse(val, NULL), PAGE_SIZE);
 
 		if (!strcmp(param, "vmalloc") && val) {
-			vmalloc_size = round_up(memparse(val, NULL), PAGE_SIZE);
+			vmalloc_size = round_up(memparse(val, NULL), _SEGMENT_SIZE);
 			vmalloc_size_set = 1;
 		}
 
diff --git a/arch/s390/boot/startup.c b/arch/s390/boot/startup.c
index 8104e0e3d188..9cc76e631759 100644
--- a/arch/s390/boot/startup.c
+++ b/arch/s390/boot/startup.c
@@ -255,7 +255,8 @@ static unsigned long setup_kernel_memory_layout(void)
 	VMALLOC_END = MODULES_VADDR;
 
 	/* allow vmalloc area to occupy up to about 1/2 of the rest virtual space left */
-	vmalloc_size = min(vmalloc_size, round_down(VMALLOC_END / 2, _REGION3_SIZE));
+	vsize = round_down(VMALLOC_END / 2, _SEGMENT_SIZE);
+	vmalloc_size = min(vmalloc_size, vsize);
 	VMALLOC_START = VMALLOC_END - vmalloc_size;
 
 	/* split remaining virtual space between 1:1 mapping & vmemmap array */
-- 
2.43.0


             reply	other threads:[~2024-01-16  1:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  1:03 Sasha Levin [this message]
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 02/21] arch: consolidate arch_irq_work_raise prototypes Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 03/21] arch: fix asm-offsets.c building with -Wmissing-prototypes Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 04/21] s390/vfio-ap: fix sysfs status attribute for AP queue devices Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 05/21] Hexagon: Make pfn accessors statics inlines Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 06/21] s390/ptrace: handle setting of fpc register correctly Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 07/21] KVM: s390: fix setting of fpc register Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 08/21] arm64: Fix circular header dependency Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 09/21] sysctl: Fix out of bounds access for empty sysctl registers Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 10/21] SUNRPC: Fix a suspicious RCU usage warning Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 11/21] ext4: enable dioread_nolock as default for bs < ps case Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 12/21] ext4: treat end of range as exclusive in ext4_zero_range() Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 13/21] smb: client: Fix minor whitespace errors and warnings Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 14/21] smb: client: fix renaming of reparse points Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 15/21] smb: client: fix hardlinking " Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 16/21] cifs: fix in logging in cifs_chan_update_iface Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 17/21] ecryptfs: Reject casefold directory inodes Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 18/21] ext4: fix inconsistent between segment fstrim and full fstrim Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 19/21] ext4: unify the type of flexbg_size to unsigned int Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 20/21] ext4: remove unnecessary check from alloc_flex_gd() Sasha Levin
2024-01-16  1:03 ` [PATCH AUTOSEL 6.7 21/21] ext4: avoid online resizing failures due to oversized flex bg Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116010422.217925-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox