public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: stable@vger.kernel.org, Eric Curtin <ecurtin@redhat.com>,
	Neal Gompa <neal@gompa.dev>, Miguel Ojeda <ojeda@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	bpf@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>,
	Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
	Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCH stable 6.1 1/2] btf, scripts: Exclude Rust CUs with pahole
Date: Wed, 17 Jan 2024 12:02:24 +0100	[thread overview]
Message-ID: <2024011707-alarm-juniper-2bfd@gregkh> (raw)
In-Reply-To: <20240117094424.487462-2-jolsa@kernel.org>

On Wed, Jan 17, 2024 at 10:44:23AM +0100, Jiri Olsa wrote:
> From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
> 
> commit c1177979af9c616661a126a80dd486ad0543b836 upstream.
> 
> Version 1.24 of pahole has the capability to exclude compilation units (CUs)
> of specific languages [1] [2]. Rust, as of writing, is not currently supported
> by pahole and if it's used with a build that has BTF debugging enabled it
> results in malformed kernel and module binaries [3]. So it's better for pahole
> to exclude Rust CUs until support for it arrives.
> 
> Co-developed-by: Eric Curtin <ecurtin@redhat.com>
> Signed-off-by: Eric Curtin <ecurtin@redhat.com>
> Signed-off-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> Tested-by: Eric Curtin <ecurtin@redhat.com>
> Reviewed-by: Neal Gompa <neal@gompa.dev>
> Acked-by: Miguel Ojeda <ojeda@kernel.org>
> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=49358dfe2aaae4e90b072332c3e324019826783f [1]
> Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=8ee363790b7437283c53090a85a9fec2f0b0fbc4 [2]
> Link: https://github.com/Rust-for-Linux/linux/issues/735 [3]
> Link: https://lore.kernel.org/bpf/20230111152050.559334-1-yakoyoku@gmail.com
> ---

You are forwarding this patch on, you also need to sign-off on it :(

thanks,

greg k-h

  reply	other threads:[~2024-01-17 11:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  9:44 [PATCH stable 6.1 0/2] btf, scripts: Update pahole options Jiri Olsa
2024-01-17  9:44 ` [PATCH stable 6.1 1/2] btf, scripts: Exclude Rust CUs with pahole Jiri Olsa
2024-01-17 11:02   ` Greg KH [this message]
2024-01-17  9:44 ` [PATCH stable 6.1 2/2] bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25 Jiri Olsa
2024-01-17 11:02   ` Greg KH
2024-01-17 13:19     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024011707-alarm-juniper-2bfd@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=acme@redhat.com \
    --cc=alan.maguire@oracle.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=ecurtin@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=neal@gompa.dev \
    --cc=ojeda@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=yakoyoku@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox