From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4249712CDA3; Tue, 23 Jan 2024 00:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968962; cv=none; b=OgUoQAqBi3pEVzVqsPaU7MpiEOqdb53ln6n02sHpJIf230usMsKWou8M2i8m0GHksjUR4eS8AuMn4WFyjC3aq7+YC9jaohvhCxK8S5BEpVbmcJmkE9UtAboLcuz2lH9ezkZp0CQ/1IPtGy6Vsm3cTagx225TrxD6F5S+FVwcrZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968962; c=relaxed/simple; bh=kSuf6m6gQz5IDHApD7370nNmPGPaYFolgHVk2V3lKhE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jc/q5FkPJqp64JxJrj4dcm4WGLx4BmS8SbEE9gfJkzN9F9vzkbwdJhhx4fJafdRnK8kJeBK/GLHTMcFesCrunxIVAWHbbu739T0L7Ln7+vZ96AhOTxGS7qQsu7WLYVs1vU6y8KG4wmYF5TLQgzSmk7SJTJkezvfQxP2Z/T86zsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gExWwxfw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gExWwxfw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4373C433C7; Tue, 23 Jan 2024 00:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705968962; bh=kSuf6m6gQz5IDHApD7370nNmPGPaYFolgHVk2V3lKhE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gExWwxfwgNJoQ7qs7ZokL+kNNIYJn7o0TaslnVdQJo0IPPSQXLYS229t7nbv8GIVn +4+PesFcwHyXFlKaGXUjgcced9oLhrPWjH5xrWeWxMgUCleJnHGno1xN3GrLXSfM0M OuC6RtSYpnw1DZy50u6lt2KF0UlqJEj1mygQgcPw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maxime Ripard , Tomi Valkeinen , Sasha Levin Subject: [PATCH 5.4 124/194] drm/bridge: tc358767: Fix return value on error case Date: Mon, 22 Jan 2024 15:57:34 -0800 Message-ID: <20240122235724.552333723@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235719.206965081@linuxfoundation.org> References: <20240122235719.206965081@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tomi Valkeinen [ Upstream commit 32bd29b619638256c5b75fb021d6d9f12fc4a984 ] If the hpd_pin is invalid, the driver returns 'ret'. But 'ret' contains 0, instead of an error value. Return -EINVAL instead. Fixes: f25ee5017e4f ("drm/bridge: tc358767: add IRQ and HPD support") Acked-by: Maxime Ripard Signed-off-by: Tomi Valkeinen Link: https://patchwork.freedesktop.org/patch/msgid/20231103-uninit-fixes-v2-4-c22b2444f5f5@ideasonboard.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 0454675a44cb..a58943115241 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1574,7 +1574,7 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id) } else { if (tc->hpd_pin < 0 || tc->hpd_pin > 1) { dev_err(dev, "failed to parse HPD number\n"); - return ret; + return -EINVAL; } } -- 2.43.0