From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BD6D62814; Tue, 23 Jan 2024 00:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971138; cv=none; b=KdhEl8eTYlQXIGGCz+oEjl921+L7EG5Wak4dajy7fJdrJcI3PNwb4SQxm+ym9r+b3UVkvHwVet0jM4MtEjYc7hmeO2jLQQyiCkC/W11qaUkZC6yQQ7fprN2HWS250QsTmw2wDHCioWjXLHToGrwOIFswtZwlr4EaGICdOqP5cTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971138; c=relaxed/simple; bh=LCtYnopr7599kg5vWIQSIDWSZtPlar3LSN5nnugy7Jc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oPRmzAkQuoXQGr4ekv+Hz+GAqw8FiwZi6TtvDRcfcUozJ2GBBzZ8sysUgNmsXXvGAmbF3Ij0Up0wvf9Y4rhqZCyOWPZ+EO/Df/7z5E/5Mi5qZWPBoyg65H1hGp8E+CxPVyAdA/Bz99FLgROAQabWQPm0L6gP/glv3ZtJhTPTff4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lCNVm60x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lCNVm60x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B69DC43390; Tue, 23 Jan 2024 00:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705971137; bh=LCtYnopr7599kg5vWIQSIDWSZtPlar3LSN5nnugy7Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lCNVm60xSUwGRwtASfiNWmsc0NG55dfTqwnAoVtmsmSxVRZh+7ZeNtvL3oPXsrnQs 0uJQB82MtvaTwYCxFOGHs8sVXTlcF/VWtwV820daSPyOLKL3Y+zEXCNTRhVDwjO34h JdFNAfyIy0vJudI2CF5xNoy8wUvwktIaIIrmBaGs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Osama Muhammad , Andreas Gruenbacher , Sasha Levin , syzbot+da0fc229cc1ff4bb2e6d@syzkaller.appspotmail.com Subject: [PATCH 5.10 096/286] gfs2: Fix kernel NULL pointer dereference in gfs2_rgrp_dump Date: Mon, 22 Jan 2024 15:56:42 -0800 Message-ID: <20240122235735.762506094@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235732.009174833@linuxfoundation.org> References: <20240122235732.009174833@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Osama Muhammad [ Upstream commit 8877243beafa7c6bfc42022cbfdf9e39b25bd4fa ] Syzkaller has reported a NULL pointer dereference when accessing rgd->rd_rgl in gfs2_rgrp_dump(). This can happen when creating rgd->rd_gl fails in read_rindex_entry(). Add a NULL pointer check in gfs2_rgrp_dump() to prevent that. Reported-and-tested-by: syzbot+da0fc229cc1ff4bb2e6d@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=da0fc229cc1ff4bb2e6d Fixes: 72244b6bc752 ("gfs2: improve debug information when lvb mismatches are found") Signed-off-by: Osama Muhammad Signed-off-by: Andreas Gruenbacher Signed-off-by: Sasha Levin --- fs/gfs2/rgrp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index ac0715aafa8e..1ffdc4ad6246 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -2231,7 +2231,7 @@ void gfs2_rgrp_dump(struct seq_file *seq, struct gfs2_rgrpd *rgd, (unsigned long long)rgd->rd_addr, rgd->rd_flags, rgd->rd_free, rgd->rd_free_clone, rgd->rd_dinodes, rgd->rd_reserved, rgd->rd_extfail_pt); - if (rgd->rd_sbd->sd_args.ar_rgrplvb) { + if (rgd->rd_sbd->sd_args.ar_rgrplvb && rgd->rd_rgl) { struct gfs2_rgrp_lvb *rgl = rgd->rd_rgl; gfs2_print_dbg(seq, "%s L: f:%02x b:%u i:%u\n", fs_id_buf, -- 2.43.0