From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C56064A80; Tue, 23 Jan 2024 00:54:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971277; cv=none; b=b1Gr9k3UmYUDyEKOJppMffrv3lFX/UF8EXq8NLpBc4qvedCQnbly2SSePuyLUA3iyQFB804+3PcNZtvXvYtueMRb8MG+WK/h4CgNqOVk5XWazPJCmLk/JyxWiRPSasvA4qpSH+PP11IJZDkuB703Z4VCPSt+x472FJo+Ws5Qi5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971277; c=relaxed/simple; bh=jclE65WoMfMo6/EYEh4Oi3qlNMye/emCgEbec2zSiR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qw/cd9WhBnygOWpoNHQsnBQ+3g7FF3uPcRssKbl/TBkNCc7qHoj4/aXgcfL3SkiAIOr8+izy2lZrOufWTNg7Y32ZrGnD5eGuLmGzVcAsZChj7kEVdIL1SRo4QbFWriUDCoexYeNyD168MafCp3K7sBLhZCCc6QHUAgODn/8+Kz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EKqHNP/a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EKqHNP/a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C63FC433F1; Tue, 23 Jan 2024 00:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705971277; bh=jclE65WoMfMo6/EYEh4Oi3qlNMye/emCgEbec2zSiR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKqHNP/aDHJZW5ybpNJUjz5QZz3W6hj+RfJmZeC1o5C5yF4/4q623W/U5d38aVJbV X+R543Tw+typZJ45gNB349NgsasVz0qvn1J4lt06FEroyO4fXxakilA77IywsFUNp0 aF+lAZI95+tpJ13HInKZSUpDH1exHP/KGIPkfAlw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ovidiu Panait , Herbert Xu , Sasha Levin Subject: [PATCH 5.10 102/286] crypto: sahara - improve error handling in sahara_sha_process() Date: Mon, 22 Jan 2024 15:56:48 -0800 Message-ID: <20240122235736.010609768@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235732.009174833@linuxfoundation.org> References: <20240122235732.009174833@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ovidiu Panait [ Upstream commit 5deff027fca49a1eb3b20359333cf2ae562a2343 ] sahara_sha_hw_data_descriptor_create() returns negative error codes on failure, so make sure the errors are correctly handled / propagated. Fixes: 5a2bb93f5992 ("crypto: sahara - add support for SHA1/256") Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/sahara.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index 67960acd786a..0ac793f03e28 100644 --- a/drivers/crypto/sahara.c +++ b/drivers/crypto/sahara.c @@ -987,7 +987,10 @@ static int sahara_sha_process(struct ahash_request *req) return ret; if (rctx->first) { - sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0); + ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0); + if (ret) + return ret; + dev->hw_desc[0]->next = 0; rctx->first = 0; } else { @@ -995,7 +998,10 @@ static int sahara_sha_process(struct ahash_request *req) sahara_sha_hw_context_descriptor_create(dev, rctx, req, 0); dev->hw_desc[0]->next = dev->hw_phys_desc[1]; - sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1); + ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1); + if (ret) + return ret; + dev->hw_desc[1]->next = 0; } -- 2.43.0