From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93FC04E1AD; Tue, 23 Jan 2024 00:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971368; cv=none; b=txQSmUGgoxh1F1MPJ3a3iju+wRoY4Opx65iovCEgdZNrUdqgF8gLLjZs7GXYYf1Gy/5M9QcOxF3VtTn0kJx2QNMCd9ecmflDXaFpkwiCQNhftUX+AXuLr2U+1pFR+hR16vWKqnlbPOXGIVf5PkRZvVR63IpNnMuP85y7m2+B9hc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971368; c=relaxed/simple; bh=78gfodtCcHCVtvxeG9WL72YqVaXM27Ymgb8OKWdrgMM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I3Qd/yCIRWXzQ3d3C66daB0qJQ2bCA/LlSiKqoagzH3ms/j4p6fFocmkHKv8JSi31TH4HfPI12BloFXfHDmix058zOkroGoLPaHD5umxj/OaWFWFJdSLlEV9x1WgvKhfCyxWSsrKVkHwdT6fAIwQ58uxGZjGDlUmslM3JQY53jM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aq4XxF9K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aq4XxF9K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F2AAC433C7; Tue, 23 Jan 2024 00:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705971368; bh=78gfodtCcHCVtvxeG9WL72YqVaXM27Ymgb8OKWdrgMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aq4XxF9KENBziLREh6SD5W+eJkSz26s6gBFCJADmSBJetolKqPWF6DIrWxL6Kk+UA XhFNLi2PY4mey7ypjTQn0JkuQ+BnSCY74BZcGKAzmJAoOlhgv/HU9y1HhFEUpiIQXR Ribtavsh6K+gLd2KQxff71qpj8TLUZfytuSXMWUU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Francesco Dolcini , Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 5.10 141/286] Bluetooth: btmtkuart: fix recv_buf() return value Date: Mon, 22 Jan 2024 15:57:27 -0800 Message-ID: <20240122235737.571205195@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235732.009174833@linuxfoundation.org> References: <20240122235732.009174833@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Francesco Dolcini [ Upstream commit 64057f051f20c2a2184b9db7f8037d928d68a4f4 ] Serdev recv_buf() callback is supposed to return the amount of bytes consumed, therefore an int in between 0 and count. Do not return negative number in case of issue, just print an error and return count. This fixes a WARN in ttyport_receive_buf(). Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851a-5e1e3ea5cfcc@kernel.org/ Fixes: 7237c4c9ec92 ("Bluetooth: mediatek: Add protocol support for MediaTek serial devices") Signed-off-by: Francesco Dolcini Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- drivers/bluetooth/btmtkuart.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/bluetooth/btmtkuart.c b/drivers/bluetooth/btmtkuart.c index 719d4685a2dd..1a908827b1f2 100644 --- a/drivers/bluetooth/btmtkuart.c +++ b/drivers/bluetooth/btmtkuart.c @@ -471,7 +471,7 @@ mtk_stp_split(struct btmtkuart_dev *bdev, const unsigned char *data, int count, return data; } -static int btmtkuart_recv(struct hci_dev *hdev, const u8 *data, size_t count) +static void btmtkuart_recv(struct hci_dev *hdev, const u8 *data, size_t count) { struct btmtkuart_dev *bdev = hci_get_drvdata(hdev); const unsigned char *p_left = data, *p_h4; @@ -510,25 +510,20 @@ static int btmtkuart_recv(struct hci_dev *hdev, const u8 *data, size_t count) bt_dev_err(bdev->hdev, "Frame reassembly failed (%d)", err); bdev->rx_skb = NULL; - return err; + return; } sz_left -= sz_h4; p_left += sz_h4; } - - return 0; } static int btmtkuart_receive_buf(struct serdev_device *serdev, const u8 *data, size_t count) { struct btmtkuart_dev *bdev = serdev_device_get_drvdata(serdev); - int err; - err = btmtkuart_recv(bdev->hdev, data, count); - if (err < 0) - return err; + btmtkuart_recv(bdev->hdev, data, count); bdev->hdev->stat.byte_rx += count; -- 2.43.0