From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D423912DD89; Tue, 23 Jan 2024 00:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971492; cv=none; b=s7PLDF3pneTcu4eBIY6zk9GH//R7/HWqC7ui1N0vhbumK0Qh0cy68h7B3hy0+9vyrE8uuc3YbESAYJpwHbzf0uawnksRN3VZpyJ9UuNb2Bx1mBAd9tbipLvY12NErRFl3UXD7Np/eqjFCXVOu56U1YoNvAyfzIdqi+Te/7Op0ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971492; c=relaxed/simple; bh=+sK3TonfcDxfIrM0RrdBhN4wrKS8vjCYJmjJIbZXywE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d8wMHEOJNwN5RuzJLcGYaK0Kxq1bzxvT14r+gHSabYqr0tyAsArR/pMR2rY7pWQncb6tcvnJ2kwBppyCCLMnA1yiJwJG6nrmyXZCD+GPOq+h+RxDBPfpKXsyhwTEi4FbAHiUWDHyytfPHTtCQrqI0qepcFTwqOe6/9oXuYp875M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rTg8Nolg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rTg8Nolg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B8D5C43390; Tue, 23 Jan 2024 00:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705971492; bh=+sK3TonfcDxfIrM0RrdBhN4wrKS8vjCYJmjJIbZXywE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rTg8NolgNEh38MOYciGpV7rwMlhiC4k7RtBcvdvN2yypTt2yFQD1zjagFE4f3tn3/ sqhaYyWLqnusumne/4v+YZUf70CtLtHHYiRbuCCTR0Nc/tioqmGNZaMS5lb2cjfYFF +viDjonqQdK4Vk2AR5YdyroxwAXvG5zUTBHh+Q68= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Yingliang , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 160/286] drm/radeon: check the alloc_workqueue return value in radeon_crtc_init() Date: Mon, 22 Jan 2024 15:57:46 -0800 Message-ID: <20240122235738.339082515@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235732.009174833@linuxfoundation.org> References: <20240122235732.009174833@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Yingliang [ Upstream commit 7a2464fac80d42f6f8819fed97a553e9c2f43310 ] check the alloc_workqueue return value in radeon_crtc_init() to avoid null-ptr-deref. Fixes: fa7f517cb26e ("drm/radeon: rework page flip handling v4") Signed-off-by: Yang Yingliang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/radeon/radeon_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 71bdafac9210..07d23a1e62a0 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -689,11 +689,16 @@ static void radeon_crtc_init(struct drm_device *dev, int index) if (radeon_crtc == NULL) return; + radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0); + if (!radeon_crtc->flip_queue) { + kfree(radeon_crtc); + return; + } + drm_crtc_init(dev, &radeon_crtc->base, &radeon_crtc_funcs); drm_mode_crtc_set_gamma_size(&radeon_crtc->base, 256); radeon_crtc->crtc_id = index; - radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0); rdev->mode_info.crtcs[index] = radeon_crtc; if (rdev->family >= CHIP_BONAIRE) { -- 2.43.0