From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE0A657B3; Tue, 23 Jan 2024 01:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971802; cv=none; b=mbwmfNNqaNz90ebmubGDdCYuDlaUb5KXHghC7DZRH1EHJzwNfAgpLmHrnY3pYwGxT4WWK5Na9WibmCq5hC8B5RvRk01tPsiwa/rGxxXRSx7rewW/LV6UW8fEpyYKgvg0zzk0HvrjrOZB5t1mbz1C6kPaBnpxEim7QeHQdJXUcg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705971802; c=relaxed/simple; bh=5Hdz+zNOHQwn7NEMvLqxE7UBmtDa3cT+uG/1POdeN9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kzv6AD/bFVoARbZGt3R8e/D62k6aG2kge8JGlw9/4kG6Naj+m41PPUf0ld9VS+DR7LaKJ6hQvjwCa+uBkR6qMRTycWEAJLTJTu/yw8rjzWt5KUohtHak3L7OtnPz5w+u3s5ozVd+wq7keNmhC+scjYfe6M46wfCiRFrtDh7d6AU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eiUJRCUK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eiUJRCUK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 622C2C433F1; Tue, 23 Jan 2024 01:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705971802; bh=5Hdz+zNOHQwn7NEMvLqxE7UBmtDa3cT+uG/1POdeN9Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eiUJRCUKttGxq4uwVtkgw0Fy7TSG2cqOc/CBbJ7XCqPX/bSBImW6CcG+1Fz2JZnDi giQY/ZLox6TkzaAs4m10/CiQ3mvN3LcUJjOro/v6lyu1aT3VQt9kghIgd3dQGVMYBI EY8y/5st97jHjHQq+YjsOFqMpl77M7aBBFiEp6T4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marcelo Schmitt , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.10 234/286] iio: adc: ad7091r: Pass iio_dev to event handler Date: Mon, 22 Jan 2024 15:59:00 -0800 Message-ID: <20240122235741.084093799@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235732.009174833@linuxfoundation.org> References: <20240122235732.009174833@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marcelo Schmitt commit a25a7df518fc71b1ba981d691e9322e645d2689c upstream. Previous version of ad7091r event handler received the ADC state pointer and retrieved the iio device from driver data field with dev_get_drvdata(). However, no driver data have ever been set, which led to null pointer dereference when running the event handler. Pass the iio device to the event handler and retrieve the ADC state struct from it so we avoid the null pointer dereference and save the driver from filling the driver data field. Fixes: ca69300173b6 ("iio: adc: Add support for AD7091R5 ADC") Signed-off-by: Marcelo Schmitt Link: https://lore.kernel.org/r/5024b764107463de9578d5b3b0a3d5678e307b1a.1702746240.git.marcelo.schmitt1@gmail.com Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/ad7091r-base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/iio/adc/ad7091r-base.c +++ b/drivers/iio/adc/ad7091r-base.c @@ -174,8 +174,8 @@ static const struct iio_info ad7091r_inf static irqreturn_t ad7091r_event_handler(int irq, void *private) { - struct ad7091r_state *st = (struct ad7091r_state *) private; - struct iio_dev *iio_dev = dev_get_drvdata(st->dev); + struct iio_dev *iio_dev = private; + struct ad7091r_state *st = iio_priv(iio_dev); unsigned int i, read_val; int ret; s64 timestamp = iio_get_time_ns(iio_dev); @@ -234,7 +234,7 @@ int ad7091r_probe(struct device *dev, co if (irq) { ret = devm_request_threaded_irq(dev, irq, NULL, ad7091r_event_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, name, st); + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, name, iio_dev); if (ret) return ret; }