From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662AC15B975; Mon, 29 Jan 2024 17:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548608; cv=none; b=hkMk915wSx8x0XE6ue/mtQtwj1jf9c8e+PF5zZj7VoumGsDy1738yoHkzGzAdDG7EZIP/zQbwPzeVM3g6ENGReFpFZnOYVBNL9EOwe3tGgC+nDKAMHjArxEHcAsRXcLJDmOotUiJEawGH5u5p0XXCPhJ3CwjLTnz8ka3wespWt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706548608; c=relaxed/simple; bh=rULr6lInr3S3QEwYuBv4r3yrzUY+O7WV+QGen10QEqI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TE/0RODi9+QQHfhues+ViImF7MKOmEkiBVYVh2DYigkc6rvxcVPmuzWdV0CVMQZjAx/E1pH1Quf9apItkgZ+h6lnBR7dpDPtz8KSWQUs+3jQTuKRx53l2lfAa7kkdgHgeqUQ0g81Wnd0X2m0pFlwRChgODpvsZd4Q0WlNWpR8Rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=U6dsPlq/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="U6dsPlq/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B827C433C7; Mon, 29 Jan 2024 17:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706548608; bh=rULr6lInr3S3QEwYuBv4r3yrzUY+O7WV+QGen10QEqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U6dsPlq/IW2QSuwkGwdLR+thalWBxkAKF5cyJtvlLrHuEL46akXB+nSVhV4g1+x4V 31zK6D5K1geefpQII6iWpBxjD0P9oHNp9nRCBcoIRTfmmIjGim8zTV/XauQZivoI/M Hgovto2UFby/SlMagmyl8Gx8sDy9tKw/iD2bMM8Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jaak Ristioja , Huacai Chen , Thomas Zimmermann , Javier Martinez Canillas , Thorsten Leemhuis , Jani Nikula , Jani Nikula Subject: [PATCH 6.6 249/331] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync" Date: Mon, 29 Jan 2024 09:05:13 -0800 Message-ID: <20240129170022.172617266@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240129170014.969142961@linuxfoundation.org> References: <20240129170014.969142961@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Zimmermann commit d1b163aa0749706379055e40a52cf7a851abf9dc upstream. This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4. Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit. To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so. Reported-by: Jaak Ristioja Closes: https://lore.kernel.org/dri-devel/ZUnNi3q3yB3zZfTl@P70.localdomain/T/#t Reported-by: Huacai Chen Closes: https://lore.kernel.org/dri-devel/20231108024613.2898921-1-chenhuacai@loongson.cn/ Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10133 Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Thorsten Leemhuis Cc: Jani Nikula Cc: stable@vger.kernel.org # v6.5+ Reviewed-by: Javier Martinez Canillas Acked-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20240123120937.27736-1-tzimmermann@suse.de Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/firmware/sysfb.c +++ b/drivers/firmware/sysfb.c @@ -128,4 +128,4 @@ unlock_mutex: } /* must execute after PCI subsystem for EFI quirks */ -subsys_initcall_sync(sysfb_init); +device_initcall(sysfb_init);